Bug 422971 - Sort Unsplash POTD image categories alphabetically
Summary: Sort Unsplash POTD image categories alphabetically
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image Wallpaper (show other bugs)
Version: 5.19.0
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2020-06-14 14:18 UTC by Matej Mrenica
Modified: 2021-07-22 18:20 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22.4


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2020-06-14 14:18:55 UTC
SUMMARY
Currently they are sorted randomly / not sorted, and it would make sense to sort them. The only issue I can see, is they need to be translated first and only then sorted otherwise they would appear unsorted.
Comment 1 Nate Graham 2020-06-19 01:24:34 UTC
Should be easy to do using a sortFilterModel.

Let me know if you'd like to learn how to do that!
Comment 2 Matej Mrenica 2020-06-20 14:19:11 UTC
Sure I would. Where should I begin? What repo does this belong to? Do I need a special environment? I am guessing it won't be easily to build on Arch.
Comment 3 Nate Graham 2020-06-22 14:32:38 UTC
In this case it's pretty darn simple. You just re-arrange these items to be alphabetically ordered: https://invent.kde.org/plasma/kdeplasma-addons/-/blob/master/wallpapers/potd/contents/ui/config.qml#L82

Perhaps "All" should remain on top, though.

Since this is a QML file, you don't even need to set up a development environment; you can test the changes locally on your own system. The file should be located at /usr/share/plasma/wallpapers/org.kde.potd/contents/ui/config.qml.

Let me know if you get stuck and need a helping hand!
Comment 4 Bug Janitor Service 2021-06-26 15:58:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/78
Comment 5 Nate Graham 2021-07-22 18:18:42 UTC
Git commit 44c85476fad0eb559d7319feedc4b5daff26aa8c by Nate Graham, on behalf of Arnaud Vergnet.
Committed on 22/07/2021 at 18:17.
Pushed by ngraham into branch 'master'.

Sort Unsplash POTD image categories alphabetically

M  +40   -40   wallpapers/potd/contents/ui/config.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/44c85476fad0eb559d7319feedc4b5daff26aa8c
Comment 6 Nate Graham 2021-07-22 18:19:29 UTC
Git commit ed7c2c218ee3cae72115f7e66ee57ee2878bdda8 by Nate Graham, on behalf of Arnaud Vergnet.
Committed on 22/07/2021 at 18:19.
Pushed by ngraham into branch 'Plasma/5.22'.

Sort Unsplash POTD image categories alphabetically


(cherry picked from commit 44c85476fad0eb559d7319feedc4b5daff26aa8c)

M  +40   -40   wallpapers/potd/contents/ui/config.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/ed7c2c218ee3cae72115f7e66ee57ee2878bdda8