Bug 422917 - Opening vault opens it in file manager
Summary: Opening vault opens it in file manager
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-13 13:40 UTC by Alexandre CATTEAU
Modified: 2020-06-16 13:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre CATTEAU 2020-06-13 13:40:30 UTC
SUMMARY
From Plasma 5.19, the vault I open (ie. unlock) via Plasma Vault automatically opens in my file manager.


STEPS TO REPRODUCE
1. Have a vault set up in Plasma Vault
2. Open this vault (click on "Vaults", "Open Vault", and enter password)

OBSERVED RESULT
The vault is opened (unlocked) and the file manager is launched in the vault mount point.

EXPECTED RESULT
I would only expect the vault to be opened, not the file manager.


SOFTWARE/OS VERSIONS
Arch Linux
KDE Plasma Version: 5.19.0
KDE Frameworks Version: 5.70.0
Qt Version: 5.15.0
Comment 1 Nate Graham 2020-06-13 15:02:19 UTC
This was an intentional change. The reasoning was that after opening the vault, you actually want to *do* something with it, which for the vast majority of users will involve a GUI, which means that a file manager is helpful.

What's your use case?
Comment 2 Alexandre CATTEAU 2020-06-13 16:26:41 UTC
In this particular use case, I use the vault to store files used by an application (say, a Thunderbird profile). Thus, after unlocking the vault, I just need to open said application.

Now, I understand perfectly that this may not be the the major use case. But could we consider the choice to open or not the file manager automatically an option (global or per vault)?

I would also point that there is a command to open file manager in the Vault "manager".
Comment 3 Nate Graham 2020-06-13 16:31:29 UTC
Ah I see. That other option is now redundant and could perhaps be changed to open the vault without showing the file manager. I'll see if I can work on that.
Comment 4 Nate Graham 2020-06-15 23:50:39 UTC
Working on this.
Comment 5 Nate Graham 2020-06-16 00:06:28 UTC
Will be fixed with https://invent.kde.org/plasma/plasma-vault/-/merge_requests/4
Comment 6 Nate Graham 2020-06-16 13:34:25 UTC
Git commit 9eefb78c95bfe612336bdf8d7474340cea1960c0 by Nate Graham.
Committed on 16/06/2020 at 13:34.
Pushed by ngraham into branch 'Plasma/5.19'.

[applet] Restore former default action

The default was changed in the ExpandibleListItem port to "Open with
file manager" in the interests of having better defaults, but this
change was ill-considered for the following reasons:
1. It left no way to only open the vault without also opening a file
   manager, which apparently is a real and valid use case
2. The "Open with file manager" item in the expanded view became totally
   redundant

I still think that opening in the file manager is a better default, but
that change needs to be done properly, and doing so requires string
and icon changes and further adjustments in the applet which are not
suitable for 5.19. So for now, let's revert to the pre-5.19 behavior to
unbreak people.
FIXED-IN: 5.19.1

M  +1    -5    plasma/package/contents/ui/VaultItem.qml

https://invent.kde.org/plasma/plasma-vault/commit/9eefb78c95bfe612336bdf8d7474340cea1960c0