Bug 422866 - In GtkAssistant's left sidebar, normal text is overlapped by black foreground
Summary: In GtkAssistant's left sidebar, normal text is overlapped by black foreground
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-12 11:43 UTC by Ilhan Yesil
Modified: 2020-08-05 20:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.20


Attachments
Text overlapped with black background (98.50 KB, image/jpeg)
2020-06-25 08:25 UTC, Ilhan Yesil
Details
Text can be seen if background color is set (91.49 KB, image/jpeg)
2020-06-25 08:25 UTC, Ilhan Yesil
Details
Screenshot LibreOffice-internal mail merge wizard (before) (83.88 KB, image/png)
2020-06-25 10:41 UTC, Michael Weghorn
Details
Screenshot LibreOffice-internal mail merge wizard (with modification from comment 4) (41.99 KB, image/png)
2020-06-25 10:46 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilhan Yesil 2020-06-12 11:43:34 UTC
SUMMARY
If GtkAssistant is used in a dialog, in GtkAssistant's left sidebar, normal text is overlapped by black foreground

STEPS TO REPRODUCE
1. Open a dialog with GtkAssistant
2. Add some items

OBSERVED RESULT
Only the first, selected item is visible, the other items are invisible because they are overlapped by a black foreground.

EXPECTED RESULT
All items should be visible.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Debian 10 buster
(available in About System)
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2020-06-12 20:40:59 UTC
A screenshot would be very helpful.
Comment 2 Ilhan Yesil 2020-06-25 08:25:07 UTC
Created attachment 129659 [details]
Text overlapped with black background
Comment 3 Ilhan Yesil 2020-06-25 08:25:49 UTC
Created attachment 129660 [details]
Text can be seen if background color is set
Comment 4 Ilhan Yesil 2020-06-25 08:29:43 UTC
This is a german extension for libreoffice, so I can't provide a translation. In this example, the third selection has three items. 

I've take a look in /usr/share/themes/Breeze/gtk-3.20/gtk.css:

If I add one line, I've a correct display:

assistant .sidebar {
  background-color: @theme_fg_color;
  border-top: 1px solid @borders; }
  assistant .sidebar:backdrop {
    background-color: @theme_fg_color;
    border-color: @borders; }
assistant.csd .sidebar {
  border-top-style: none; }
assistant .sidebar label {
  padding: 6px 12px; 
  background-color: @theme_bg_color;  <<---- added line
}
assistant .sidebar label.highlight {
  background-color: @extra_dull_borders; }
Comment 5 Michael Weghorn 2020-06-25 10:41:27 UTC
Created attachment 129666 [details]
Screenshot LibreOffice-internal mail merge wizard (before)

The same can be seen with LibreOffice's own mail merge dialog when using the gtk3 VCL plugin:

* start LibreOffice Writer, using gtk3 VCL plugin:

    SAL_USE_VCLPLUGIN=gtk3 libreoffice --writer

* start mail merge dialog via "Tools" -> "Mail Merge Wizard"

Attached the screenshot without the extra line.

I can confirm that adding the line as mentioned in comment 4 makes the non-active entries visible like in Ilhan's example.

(Not sure whether the fact that the unused part of the sidebar is still black is another issue, IMHO this at least looks a bit weird...)
Comment 6 Michael Weghorn 2020-06-25 10:46:44 UTC
Created attachment 129667 [details]
Screenshot LibreOffice-internal mail merge wizard (with modification from comment 4)

(This is with breeze-gtk-theme 5.17.5-2 from Debian testing and the modification mentioned in comment 4 manually applied.)
Comment 7 Michael Weghorn 2020-06-25 12:17:22 UTC
(In reply to Michael Weghorn from comment #5)
> Created attachment 129666 [details]
> [...]
> (Not sure whether the fact that the unused part of the sidebar is still
> black is another issue, IMHO this at least looks a bit weird...)

This seems to come from those lines just a few lines above, also can be seen in Ilhan's comment 4:

> assistant .sidebar {
> background-color: @theme_fg_color;

or, as it is in current master (with "@theme_text_color" instead of "theme_fg_color"):

https://invent.kde.org/plasma/breeze-gtk/-/blob/84530aee0955d5bfb561ae6267c847cd544d6084/src/gtk3/widgets/_base.scss#L203

Maybe that's intended, to have a certain contrast? I'm not a designer, and don't know much about the topic...
Comment 8 Bug Janitor Service 2020-08-03 21:33:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/6
Comment 9 Janet Blackquill 2020-08-05 20:03:12 UTC
Git commit 9c1f7f52867747d1dcb304ca31eabbdbb53ec60f by Carson Black.
Committed on 03/08/2020 at 21:33.
Pushed by cblack into branch 'master'.

Fix GTK Assistant styles to be legible

M  +1    -0    src/gtk3/gtk.scss
A  +24   -0    src/gtk3/widgets/_assistant.scss
M  +0    -19   src/gtk3/widgets/_base.scss

https://invent.kde.org/plasma/breeze-gtk/commit/9c1f7f52867747d1dcb304ca31eabbdbb53ec60f