Bug 422842 - Icons in settings UI should be the same as the icons actually displayed in the system tray
Summary: Icons in settings UI should be the same as the icons actually displayed in th...
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Night Color Control (show other bugs)
Version: 5.19.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-11 19:36 UTC by Daniel
Modified: 2021-05-04 05:05 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22
Sentry Crash Report:


Attachments
a screenshot of the night color icon in the setup system tray dialog. (6.47 KB, image/png)
2020-06-11 19:36 UTC, Daniel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2020-06-11 19:36:53 UTC
Created attachment 129242 [details]
a screenshot of the night color icon in the setup system tray dialog.

SUMMARY
a wrong icon is shown for night color in the "setup system tray" dialog. The icon if the screen setup is used.

Instead it should be the same icon as it is on the system tray.
Comment 1 Nate Graham 2020-06-12 16:31:22 UTC
This affects more than just the system tray. I think it's an issue of the Plasma theme and the icon theme having different appearances. We should probably force the icons in the settings UI to use the icons from the Plasma theme, if present. This would mirror the appearance of the tray items, which use the same logic.
Comment 2 Konrad Materka 2020-06-16 07:19:02 UTC
System tray settings shows icon defined in the applet metadata, not a current icon of the applet. This is for consistency reason - some applets changes their icon depending on their state, for example Network can show Wifi, cable etc.

For Night Color icon is defined in:
/usr/share/kservices5/plasma-applet-org.kde.plasma.nightcolorcontrol.desktop
> Icon=preferences-desktop-display-nightcolor

Such icon does not exist, so the closest possible is loaded: "preferences-desktop-display".

This is a problem in Night Color applet, it needs to provide a valid icon.
Comment 3 Rind 2021-04-29 00:27:32 UTC
> This is a problem in Night Color applet, it needs to provide a valid icon.
then should this bug be moved to kcm_nightcolor?
Comment 4 Nate Graham 2021-05-04 05:04:36 UTC
Nah, that's the place for bugs affecting the KCM and the feature in general; this bug report is about the applet.
Comment 5 Nate Graham 2021-05-04 05:05:50 UTC
Git commit c63d8862e28c250b78433f49d9417362ef17ddc7 by Nate Graham.
Committed on 04/05/2021 at 05:04.
Pushed by ngraham into branch 'master'.

[applets/nightcolor] Use same icon as will be shown in the tray
FIXED-IN: 5.22

M  +1    -1    applets/nightcolor/package/metadata.desktop

https://invent.kde.org/plasma/kdeplasma-addons/commit/c63d8862e28c250b78433f49d9417362ef17ddc7