Bug 422829 - Separate translatable string Preview in tool_transform2
Summary: Separate translatable string Preview in tool_transform2
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Translation (show other bugs)
Version: 4.3.0-beta2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-11 16:09 UTC by Tyson Tan
Modified: 2020-07-17 01:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2020-06-11 16:09:20 UTC
Preview
is used in 3 places:
#: libs/ui/forms/kis_previewwidgetbase.ui:32
#: libs/ui/forms/wdgfilterdialog.ui:63 plugins/dockers/gamutmask/forms/wdgGamutMaskChooser.ui:200
#: plugins/tools/tool_transform2/wdg_tool_transform.ui:1704

However, the one used in transform tool must be translated differently in Chinese/Japanese. Please separate that one out. Thanks!
Comment 1 Halla Rempt 2020-06-11 16:11:49 UTC
Hi Tyson,

I'm wondering whether it would make sense to give you the powers to make merge requests fixing these things? Since an MR is easier to handle than a bug report?
Comment 2 Tyson Tan 2020-06-11 16:26:49 UTC
Hi Boud, sorry for keep bothering you about these little things. 

To be honest, right now I have no idea how the strings work in the source code and I'm not really a programmer. But I'm not illiterate about it either, after dealing with Gitlab for the first time last week. 

I can try to learn, if you can tell me how. Thanks!
Comment 3 Halla Rempt 2020-06-16 08:45:19 UTC
Meh, just when I was all set to explain how to add the disambiguation property to the the widget using gitlab's web ide... I discovered that at least one of those files isn't used, and hadn't been used ever. Let me check the other ones.
Comment 4 Halla Rempt 2020-06-16 08:50:21 UTC
So... For UI files, go to for, instance

https://invent.kde.org/-/ide/project/graphics/krita/blob/master/-/plugins/tools/tool_transform2/wdg_tool_transform.ui

and add 

comment="preview the transformation of the current layer"

To the preview label.

Then press the blue commit button, add a commit message, like "Disambiguate the Preview label" and press the now green Commit button.

A merge request is now being created, and you can just copy the title to the description field, click the Delete source branch and then Submit merge request.
Comment 5 Tyson Tan 2020-06-16 12:25:08 UTC
Thank you Boud! I will look into it and give it a go. Just give me sometime before I finish translating the documentation. There are only 5 pages left now.
Comment 6 Tyson Tan 2020-07-13 02:48:07 UTC
OK, after a dozens of trying, I forked the master branch, committed changes, then made a merge request:
https://invent.kde.org/graphics/krita/-/merge_requests/423

I have no idea what I was doing at all, so I have a ton of questions:

1) Am I doing it the correct way?

2) The labels are "the same by default" unless they are commented differently? 

3) I wasn't able to follow your instruction, the website kept returning unspecified errors. Is it that I don't have the proper privilege to commit on master, or is the "fork" way the correct way (the documentation did mentioned it )?

4) Before this commit, I already forked Krita from Alvin's fork to translate the NSIS installer. But I can only have one fork of Krita at a time -- Gitlab won't let me fork from master unless I deleted the previous fork. Otherwise by clicking the "fork" button, it only took me to my fork page. I had remove the previous fork to make that fork button work again, but is that the way to do it? What if I have to work on master and someone-else's fork at the same time?

I'm sorry for asking so many questions, but I'm totally confused right now. :P
Comment 7 Tyson Tan 2020-07-17 01:03:20 UTC
OK, with you correcting my last commit, I saw the new string showing up properly in today's synchronized translation. Now I understand how to disambiguate a string. Thank you and sorry for the mistakes!

I will work on the disambiguation of other strings later. I did note quite a lot during the translation.