Bug 422713 - Backtab should be named Tab
Summary: Backtab should be named Tab
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: tabbox (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-10 04:43 UTC by Thiago Sueto
Modified: 2023-12-19 17:19 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Sueto 2020-06-10 04:43:17 UTC
I noticed that in the window switching kcm in system settings the default keyboard shortcut for reverse window switching is "Alt+Shift+Backtab", whereas the keyboard shortcuts kcm always mentions "Tab" instead.

It seems the name shown in the kcm is defined in line https://invent.kde.org/plasma/kwin/-/blob/master/tabbox/tabbox.cpp#L548 but I might be mistaken. To me it looks like it's trivial and the fix just requires renaming Qt::Key_Backtab to Qt::Key_Tab, but I'm not sure.
Comment 1 Nate Graham 2020-06-10 19:32:05 UTC
You would want to make sure that it still works, of course. But feel free to give it a try and submit a merge request!
Comment 2 Thiago Sueto 2020-06-11 20:28:28 UTC
I'm willing to do a patch, yes.
I tested compiling KWin from source, changing what I suggested and running a plasma session made with kdesrc-build, but it didn't seem to work. Either I need to do some additional steps or this is not the correct line.
Could someone point me in the right direction? Which modules are related to what is shown in keyboard shortcut buttons like those in the tabbox kcm?
Comment 3 Thiago Sueto 2021-02-07 14:25:09 UTC
This has been here for a while after I said I'd attempt this, so:
It seems to be non-trivial. The last time I tried this, simply changing that line (and other matches in KWin) made no difference, but I'll attempt working on this again soon now that I know how to use nested KWin sessions (I gather that running System Settings from a nested session should do the trick instead of building an entire session from kdesrc-build).
Comment 4 fanzhuyifan 2023-12-16 07:50:24 UTC
Is there general agreement that calling the shortcut Shift+Tab is better than calling it Shift+Backtab? If so I think it could be easily fixed. Theoretically things should still work. We just need to double check.
Comment 5 Bug Janitor Service 2023-12-18 21:21:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4807
Comment 6 fanzhuyifan 2023-12-19 17:19:43 UTC
Git commit eda442f9b03d2aa06c2b2fce17bba2fab8c83df6 by Yifan Zhu.
Committed on 19/12/2023 at 18:08.
Pushed by fanzhuyifan into branch 'master'.

kcms/tabbox: change Shift+Backtab to Shift+Tab

In default shortcuts, change +Shift+Backtab to +Shift+Tab.

Functionally the behavior doesn't change.
But Shift+Tab is better since it is
- easier to understand (not everyone knows what Backtab is)
- more consistent with other shortcuts containing Shift:
  we use Alt+Shift+1, instead of Alt+Shift+!
- more consistent with how user defined shortcuts with Shift and Tab are
  displayed and stored
FIXED-IN: 6.0

M  +1    -1    src/kcms/tabbox/shortcutsettings.cpp
M  +1    -1    src/tabbox/tabbox.cpp

https://invent.kde.org/plasma/kwin/-/commit/eda442f9b03d2aa06c2b2fce17bba2fab8c83df6