Bug 422669 - Only the first sensor value is displayed in the popup
Summary: Only the first sensor value is displayed in the popup
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Monitor (show other bugs)
Version: 5.19.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-09 12:26 UTC by Antonio Rojas
Modified: 2023-08-03 21:46 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/libksysguard/commit/3a133b7067c36e0ec36ea400908c7425ecacfdac
Version Fixed In: 5.19.2
Sentry Crash Report:

Attachments
Screenshot (57.72 KB, image/png)
2020-06-09 12:26 UTC, Antonio Rojas 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2020-06-09 12:26:32 UTC 
Created attachment 129158 [details]
Screenshot

SUMMARY
Adding a system monitor applet to the menu with two sensors, the popup only displays the (text) value of the first one. See screenshot


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Antonio Rojas 2020-06-09 12:34:25 UTC 
The same happens if you add it to the desktop, but in that case you can resize it vertically to show all values. The panel popup can't be resized
Comment 2 Bug Janitor Service 2020-06-17 16:19:39 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/28
Comment 3 Marco Martin 2020-06-19 08:25:01 UTC 
Git commit 3a133b7067c36e0ec36ea400908c7425ecacfdac by Marco Martin.
Committed on 19/06/2020 at 08:24.
Pushed by mart into branch 'Plasma/5.19'.

expose better size hints

expose size hints calculated better that make sure that when in popup
the full legend is shown
Related: bug 422888

M  +2    -0    faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
M  +9    -1    faces/facepackages/barchart/contents/ui/FullRepresentation.qml
M  +7    -0    faces/facepackages/linechart/contents/ui/FullRepresentation.qml
M  +9    -4    faces/facepackages/piechart/contents/ui/FullRepresentation.qml
M  +6    -0    faces/facepackages/textonly/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/libksysguard/commit/3a133b7067c36e0ec36ea400908c7425ecacfdac
Comment 4 Antonio Rojas 2020-06-24 06:26:01 UTC 
Still valid in 5.19.2
Comment 5 Marco Martin 2020-06-24 09:56:23 UTC 
Git commit b7d7bfb0b88195e2b973b2ddc09eedf2810da88c by Marco Martin.
Committed on 24/06/2020 at 09:40.
Pushed by mart into branch 'Plasma/5.19'.

better propagate size hints

better propagate Layout.* hints from the loaded faces to the plasmoid
object
this helps in obtaining a more crorrectly sized popup
Related: bug 422888

M  +6    -6    applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
M  +8    -13   applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
M  +8    -2    applets/systemmonitor/systemmonitor/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b7d7bfb0b88195e2b973b2ddc09eedf2810da88c
Comment 6 Noah Davis 2023-08-03 21:46:41 UTC 
This appears to be fixed now. Testing 5.26.1