Bug 422547 - Small Icons, Large Icons, and Thumbnails task switchers do not respect scale factor on X11
Summary: Small Icons, Large Icons, and Thumbnails task switchers do not respect scale ...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-tabbox (show other bugs)
Version: git master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-06 19:38 UTC by Nate Graham
Modified: 2020-07-01 17:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.6
Sentry Crash Report:
nate: Wayland-
nate: X11+


Attachments
Small Icons (2.67 MB, image/png)
2020-06-06 19:38 UTC, Nate Graham
Details
Large Icons (2.73 MB, image/png)
2020-06-06 19:39 UTC, Nate Graham
Details
Thumbnails (2.79 MB, image/png)
2020-06-06 19:40 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-06-06 19:38:49 UTC
Created attachment 129110 [details]
Small Icons

OpenSUSE Tumbleweed with Qt 5.15 and all KDE software built from today's git master.


STEPS TO REPRODUCE
1. Set scale factor to 200%
2. Reboot
3. Set task Switcher style to Small Icons, Large Icons, or Thumbnails style.

OBSERVED RESULT
When invoked, these switchers are displayed at 100% scale, not 200%, and are very small.

EXPECTED RESULT
These task Switchers respect the systemwide scale factor.
Comment 1 Nate Graham 2020-06-06 19:39:39 UTC
Created attachment 129111 [details]
Large Icons
Comment 2 Nate Graham 2020-06-06 19:40:01 UTC
Created attachment 129112 [details]
Thumbnails
Comment 3 Nate Graham 2020-06-06 21:45:53 UTC
X11 is affected; Wayland is not.
Comment 4 Nate Graham 2020-07-01 03:49:41 UTC
Working on this.
Comment 5 Bug Janitor Service 2020-07-01 04:09:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/7
Comment 6 Nate Graham 2020-07-01 14:12:07 UTC
Git commit 16ff74c0fad9230acf5ebc4ffa68dd080ce8580a by Nate Graham.
Committed on 01/07/2020 at 14:11.
Pushed by ngraham into branch 'master'.

Port task switchers to use units.iconSizes

This makes them high DPI compatible instantly as those constants are
themselves high DPI compatible. It's always better to use them rather
than specifying hardcoded integer sizes.
FIXED-IN: 5.19.3

M  +1    -1    windowswitchers/big_icons/contents/ui/main.qml
M  +2    -2    windowswitchers/compact/contents/ui/main.qml
M  +2    -2    windowswitchers/informative/contents/ui/main.qml
M  +1    -1    windowswitchers/present_windows/contents/ui/main.qml
M  +1    -1    windowswitchers/small_icons/contents/ui/main.qml
M  +1    -1    windowswitchers/thumbnail_grid/contents/ui/main.qml
M  +1    -1    windowswitchers/thumbnails/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/16ff74c0fad9230acf5ebc4ffa68dd080ce8580a
Comment 7 Nate Graham 2020-07-01 14:13:00 UTC
Git commit c3aa0010099a20defe7f931e438280cb2e9dac4c by Nate Graham.
Committed on 01/07/2020 at 14:12.
Pushed by ngraham into branch 'Plasma/5.19'.

Port task switchers to use units.iconSizes

This makes them high DPI compatible instantly as those constants are
themselves high DPI compatible. It's always better to use them rather
than specifying hardcoded integer sizes.
FIXED-IN: 5.19.3


(cherry picked from commit 16ff74c0fad9230acf5ebc4ffa68dd080ce8580a)

M  +1    -1    windowswitchers/big_icons/contents/ui/main.qml
M  +2    -2    windowswitchers/compact/contents/ui/main.qml
M  +2    -2    windowswitchers/informative/contents/ui/main.qml
M  +1    -1    windowswitchers/present_windows/contents/ui/main.qml
M  +1    -1    windowswitchers/small_icons/contents/ui/main.qml
M  +1    -1    windowswitchers/thumbnail_grid/contents/ui/main.qml
M  +1    -1    windowswitchers/thumbnails/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/c3aa0010099a20defe7f931e438280cb2e9dac4c
Comment 8 Nate Graham 2020-07-01 17:36:04 UTC
Git commit 29d0f34c6b0aad8c41a15c2227ea35764bb9d9cb by Nate Graham.
Committed on 01/07/2020 at 17:36.
Pushed by ngraham into branch 'Plasma/5.18'.

Port task switchers to use units.iconSizes

This makes them high DPI compatible instantly as those constants are
themselves high DPI compatible. It's always better to use them rather
than specifying hardcoded integer sizes.
FIXED-IN: 5.19.3


(cherry picked from commit 16ff74c0fad9230acf5ebc4ffa68dd080ce8580a)

M  +1    -1    windowswitchers/big_icons/contents/ui/main.qml
M  +2    -2    windowswitchers/compact/contents/ui/main.qml
M  +2    -2    windowswitchers/informative/contents/ui/main.qml
M  +1    -1    windowswitchers/present_windows/contents/ui/main.qml
M  +1    -1    windowswitchers/small_icons/contents/ui/main.qml
M  +1    -1    windowswitchers/thumbnail_grid/contents/ui/main.qml
M  +1    -1    windowswitchers/thumbnails/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/29d0f34c6b0aad8c41a15c2227ea35764bb9d9cb