Bug 422544 - Hardly visible UI icons in dark scheme (breeze)
Summary: Hardly visible UI icons in dark scheme (breeze)
Status: RESOLVED DUPLICATE of bug 432085
Alias: None
Product: kate
Classification: Applications
Component: application (show other bugs)
Version: 20.04.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-06 18:35 UTC by Denis
Modified: 2021-02-18 19:16 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Kate UI with Dark scheme and black icons (57.88 KB, image/png)
2020-06-06 18:36 UTC, Denis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Denis 2020-06-06 18:35:25 UTC
SUMMARY
When we use Dark scheme like Breeze, there are some UI icons that hardly visible. And there is no way to set them white instead of black.

STEPS TO REPRODUCE
1. Settings -> Color Scheme -> Breeze Dark
2. Look at UI icons (check screenshot)

OBSERVED RESULT
The icons color is black when Dark scheme is selected


EXPECTED RESULT
The icons color has to be changed to white when Dark scheme is selected

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Denis 2020-06-06 18:36:46 UTC
Created attachment 129109 [details]
Kate UI with Dark scheme and black icons
Comment 2 Nate Graham 2020-06-11 04:40:29 UTC
Works for me.

Are you using the color scheme setting in Kate itself, or in System Settings?
Comment 3 Kåre Särs 2020-06-11 06:17:53 UTC
This is on Windows :)

I think the problem is that on windows we bundle only the breeze icon-set and not the breeze-dark icons... And I'm not totally sure how the color scheme changing effects the icon theme...
Comment 4 Alain Boyer 2020-06-13 22:03:20 UTC
This bug is affecting me and I did a bit of digging.

The Breeze icons are packaged into bin/data/icontheme.rcc on Windows. Looking at the Breeze icons framework build system, this RCC file only contains the default Breeze light theme. Looking at the Craft blueprint for the Breeze icons framework, it registers a useBreezeDark option. This leads me to believe that that dark icon theme is a compile time option and Kate for Windows only ships with the default light theme.

Moreover, looking at kiconthemes, it only supports loading one RCC file for icons. It looks like a new feature would be needed to support multiple icons themes on Windows that can be modified at runtime.

As a first step, could we not package both light and dark RCC files? These will be needed once switching at runtime is supported in any case. That way, a user could rename the files to switch between icon themes.

As a second step, proper runtime switching of icon themes should be implemented.
Comment 5 Alain Boyer 2020-06-14 07:07:23 UTC
It seems that a fix is underway. See the following discussions for more information.

https://phabricator.kde.org/D24989
https://phabricator.kde.org/D25119
Comment 6 Christoph Cullmann 2021-02-18 19:15:00 UTC
This is now fixed, new version of Kate are in the store and on binary-factory.kde.org.
Comment 7 Christoph Cullmann 2021-02-18 19:16:40 UTC

*** This bug has been marked as a duplicate of bug 432085 ***