Bug 422507 - Multi-disc albums are displayed as multiple copies of the same album, if the source files are split across multiple directories
Summary: Multi-disc albums are displayed as multiple copies of the same album, if the ...
Status: CONFIRMED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 20.04.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
: 472992 494621 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-05 22:09 UTC by stigofstad
Modified: 2024-12-16 18:15 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot of the Album View showing what appears to be a duplicated album (245.76 KB, image/png)
2020-06-05 22:09 UTC, stigofstad
Details
Tags of the first file of each album (177.67 KB, image/png)
2020-06-13 08:33 UTC, stigofstad
Details
vorbis tag dump of example album (36.45 KB, text/plain)
2020-07-13 12:39 UTC, Till Schäfer
Details
playlist showing multidisk album (124.72 KB, image/png)
2020-07-13 12:43 UTC, Till Schäfer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description stigofstad 2020-06-05 22:09:37 UTC
Created attachment 129090 [details]
Screenshot of the Album View showing what appears to be a duplicated album

SUMMARY
I think it makes sense, UX wise, to group disk's from the same album together.

STEPS TO REPRODUCE
1. Two songs tagged to the same album
2. Tag song A with "Disk 1"
3. Tag song B with "Disk 2"

OBSERVED RESULT
In the UI, two identical albums.(See attachment)

EXPECTED RESULT
One album presented to the user, and when expanded, detailed view of the different disk's and songs on the album.

ADDITIONAL INFORMATION
For reference, the same thing being discussed in Amarok;
https://bugs.kde.org/show_bug.cgi?id=90503
Comment 1 Nate Graham 2020-06-11 03:32:02 UTC
That's what's supposed to happen, but I gather it isn't working for you.

When you say "Disk 1" and "Disk 2" can you verify that you're tagging them with the numbers 1 and 2 using the "Disc" property?
Comment 2 stigofstad 2020-06-13 08:33:20 UTC
Created attachment 129299 [details]
Tags of the first file of each album
Comment 3 stigofstad 2020-06-13 08:33:37 UTC
Have been using Elisa pretty much from the start, never seen this behavior working, so didn't know it was a bug, sorry about that.

But yes, the albums are being tagged with "1" and "2" on the "Disc" property. Added an image to show this.
Most of my music collection has been organized and tagged by MusicBee.

But since this is a bug, I'l provide some more information.
Elisa: 20.4.0
Plasma: 5.18.5
KDE Frameworks: 5.68.0
Qt: 5.12.8
uname -a : Linux desk 5.4.0-37-generic #41-Ubuntu SMP Wed Jun 3 18:57:02 UTC 2020 x86_64 
  x86_64 x86_64 GNU/Linux

OS-Release: 
  NAME="Ubuntu"
  VERSION="20.04 LTS (Focal Fossa)"
  ID=ubuntu
  ID_LIKE=debian
  PRETTY_NAME="Ubuntu 20.04 LTS"
  VERSION_ID="20.04"

I can also add that I'm NOT using Baloo file indexer for Elisa, as I access my media content over NFS, which Baloo does not support (probably not relevant).
Comment 4 Nate Graham 2020-06-18 22:29:14 UTC
Thanks for the info. If you could attach those files so we can try to reproduce the issue with them, that would be very helpful.
Comment 5 stigofstad 2020-06-20 07:59:22 UTC
I seems to be unable to upload any files larger than 4MB.
However, this should be easy enough to reproduce, and there is nothing special about those examples. It's the same with any 2 files tagged to the same album but different disc's.
Comment 6 Till Schäfer 2020-07-13 12:33:27 UTC
I can confirm this issue for all my multi CD albums. 

My folder/file structure is always: Album Artist - Album/CD XX/Track Number - Artist - Track Title.flac
Comment 7 Till Schäfer 2020-07-13 12:39:26 UTC
Created attachment 130082 [details]
vorbis tag dump of example album

I have attached the metaflac output of an example album: 

metaflac --list --block-type VORBIS_COMMENT */*.flac

Full folder/file structure:

$ tree .
.
├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
├── CD 01
│   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
│   ├── 01 - Etnica - The Gilis Voyage.flac
│   ├── 02 - Etnica - Infinitive Dream.flac
│   ├── 03 - Etnica - The Gilis Voyage (Ketu Remix).flac
│   ├── 04 - Etnica - Vickys Dream.flac
│   ├── 05 - Etnica - Moon Influence.flac
│   ├── 06 - Etnica - Spheric Koncept.flac
│   ├── 07 - Etnica - Mystical Apperance In Goa.flac
│   ├── 08 - Etnica - A Tribute To Goa.flac
│   ├── 09 - Etnica - Intense Visitation (Visitation Of Energy Mix).flac
│   └── folder.jpg
├── CD 02
│   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
│   ├── 01 - Etnica - The Gili's Voyage (Early Mix).flac
│   ├── 02 - Etnica - Mystical Apperance In Goa (Remix).flac
│   ├── 03 - Etnica - Asian Code 7.flac
│   ├── 04 - Etnica - Still Botta.flac
│   ├── 05 - Evolution - Alien Phenomenon.flac
│   ├── 06 - Etnica - Synthesis (Shadow Of The Moog).flac
│   ├── 07 - Etnica - Fractal Gates.flac
│   ├── 08 - Etnica - Acid Shell.flac
│   ├── 09 - Etnica - Chemical Trance (Original Mix).flac
│   └── folder.jpg
├── CD 03
│   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
│   ├── 01 - Etnica - Fingers.flac
│   ├── 02 - Etnica - Gollum.flac
│   ├── 03 - Etnica - Big Dust In Chapora For.flac
│   ├── 04 - Etnica - Whale.flac
│   ├── 05 - Etnica - Bali Island.flac
│   ├── 06 - Etnica - 38 Parallelo.flac
│   ├── 07 - Etnica - Pacific Love.flac
│   ├── 08 - Etnica - J.H. Sound.flac
│   ├── 09 - Tribe - Gilligans Island.flac
│   ├── 10 - Etnica - Evolis.flac
│   ├── 11 - Etnica - Big Dust In Chapora Fort (Piano Remix).flac
│   └── folder.jpg
├── folder.jpg
└── guideline_1.6.txt
Comment 8 Till Schäfer 2020-07-13 12:43:37 UTC
Created attachment 130083 [details]
playlist showing multidisk album

I have furthermore noticed that the problem is the same in the playlist. Each Disk is shown with its own album header (which is IMO good) but no information about hte actual disk number is given.
Comment 9 Till Schäfer 2020-07-13 12:50:42 UTC
Based on Comment 1 I have marked this as a Bug. 

Operating System: Gentoo Linux
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0
Kernel Version: 5.7.8-gentoo
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 23.5 GiB of RAM
Graphics Processor: GeForce GTX 970/PCIe/SSE2
Comment 10 Matthieu Gallien 2020-07-13 13:05:17 UTC
(In reply to Till Schäfer from comment #7)
> Created attachment 130082 [details]
> vorbis tag dump of example album
> 
> I have attached the metaflac output of an example album: 
> 
> metaflac --list --block-type VORBIS_COMMENT */*.flac
> 
> Full folder/file structure:
> 
> $ tree .
> .
> ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> ├── CD 01
> │   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> │   ├── 01 - Etnica - The Gilis Voyage.flac
> │   ├── 02 - Etnica - Infinitive Dream.flac
> │   ├── 03 - Etnica - The Gilis Voyage (Ketu Remix).flac
> │   ├── 04 - Etnica - Vickys Dream.flac
> │   ├── 05 - Etnica - Moon Influence.flac
> │   ├── 06 - Etnica - Spheric Koncept.flac
> │   ├── 07 - Etnica - Mystical Apperance In Goa.flac
> │   ├── 08 - Etnica - A Tribute To Goa.flac
> │   ├── 09 - Etnica - Intense Visitation (Visitation Of Energy Mix).flac
> │   └── folder.jpg
> ├── CD 02
> │   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> │   ├── 01 - Etnica - The Gili's Voyage (Early Mix).flac
> │   ├── 02 - Etnica - Mystical Apperance In Goa (Remix).flac
> │   ├── 03 - Etnica - Asian Code 7.flac
> │   ├── 04 - Etnica - Still Botta.flac
> │   ├── 05 - Evolution - Alien Phenomenon.flac
> │   ├── 06 - Etnica - Synthesis (Shadow Of The Moog).flac
> │   ├── 07 - Etnica - Fractal Gates.flac
> │   ├── 08 - Etnica - Acid Shell.flac
> │   ├── 09 - Etnica - Chemical Trance (Original Mix).flac
> │   └── folder.jpg
> ├── CD 03
> │   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> │   ├── 01 - Etnica - Fingers.flac
> │   ├── 02 - Etnica - Gollum.flac
> │   ├── 03 - Etnica - Big Dust In Chapora For.flac
> │   ├── 04 - Etnica - Whale.flac
> │   ├── 05 - Etnica - Bali Island.flac
> │   ├── 06 - Etnica - 38 Parallelo.flac
> │   ├── 07 - Etnica - Pacific Love.flac
> │   ├── 08 - Etnica - J.H. Sound.flac
> │   ├── 09 - Tribe - Gilligans Island.flac
> │   ├── 10 - Etnica - Evolis.flac
> │   ├── 11 - Etnica - Big Dust In Chapora Fort (Piano Remix).flac
> │   └── folder.jpg
> ├── folder.jpg
> └── guideline_1.6.txt

This is not currently supported. What is supported is the case where all discs are in the same directory. An evolution of the file indexer will be needed. Would you like to try to do it yourself?
Comment 11 Till Schäfer 2020-07-13 14:19:41 UTC
(In reply to Matthieu Gallien from comment #10)
> (In reply to Till Schäfer from comment #7)
> [...]
> This is not currently supported. What is supported is the case where all
> discs are in the same directory. An evolution of the file indexer will be
> needed. Would you like to try to do it yourself?

I will not find the time in the near future (next 6 month or so). However, if I find some spare time, I might look into this.
Comment 12 Nate Graham 2022-04-18 20:56:52 UTC
This works in the Album view now, but it still needs to be done for the Plsylist.
Comment 13 Jacob Kauffmann 2022-04-26 03:47:08 UTC
(In reply to Nate Graham from comment #12)
> This works in the Album view now, but it still needs to be done for the
> Plsylist.

This does not work in the Album view, testing with Elisa 22.04. I have an album split between two directories, with all tracks having the same Album and Album Artist tags, and they are still displayed in Elisa's album view as two separate albums. I've tried setting the disc number tags to 1/2, 2/2 and 1, 2.
Comment 14 Ray 2023-11-12 17:40:43 UTC
I can confirm this behavior still exists in Elisa 23.08.1. My multi-disc albums have all the correct metadata and the directories live side by side on a locally-mounted samba share.
Comment 15 cwo 2024-07-26 05:53:33 UTC
*** Bug 472992 has been marked as a duplicate of this bug. ***
Comment 16 John Kizer 2024-12-16 18:00:39 UTC
*** Bug 494621 has been marked as a duplicate of this bug. ***
Comment 17 John Kizer 2024-12-16 18:15:47 UTC
Updating the title to reflect what appeared to be the core issue from the original reporter of this bug, confirmed to be the case on Elisa 24.12.0 (Fedora KDE 41)