Bug 422505 - Contrast of text previews is too high
Summary: Contrast of text previews is too high
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (show other bugs)
Version: 5.68.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-05 21:48 UTC by ferweer
Modified: 2021-05-22 18:59 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
dolphin attack to eye. (7.35 KB, image/png)
2020-06-05 21:49 UTC, ferweer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ferweer 2020-06-05 21:48:23 UTC 
SUMMARY
sorry strange english.
dolphin is have issue. i know this bug older bug report. but i cant found.
maybe this bug or issue, developer said fix update is soon. that for 2020 june plans? sorry i dont have memorize. 
so, when this fix? if this bug report is duplicate. maybe that is so. sorry. 

STEPS TO REPRODUCE
1.dolphon > show panel > infomation

OBSERVED RESULT
if you used dark theme = eye gentle theme.
dolphin gap generate and attack for your eyes.
you have damaged eyes.

EXPECTED RESULT
user use gentle for eyes theme. dolphin recognize preview theme.

Operating System: Kubuntu 20.04
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8
Kernel Version: 5.4.0-33-lowlatency
OS Type: 64-bit
Comment 1 ferweer 2020-06-05 21:49:15 UTC 
Created attachment 129088 [details]
dolphin attack to eye.
Comment 2 Nate Graham 2020-06-07 03:16:48 UTC 
Can confirm. Méven, I recall that you or someone else submitted a patch to fix this. Did that ever get landed?
Comment 3 Méven Car 2020-06-08 09:00:55 UTC 
Should have been fixed with https://phabricator.kde.org/D25891 and KDE application 20.04, and Kubuntu 20.04 includes KDE application 19.12.

Fixed in 20.04, Kubuntu may perhaps provide backports. Otherwise this will be fixed in 20.10.
Comment 4 Méven Car 2020-06-08 09:04:57 UTC 
In fact this bug report is not about dark theme not being applied but how the contrast of text previews being too high.

Well you'd need to set a dark color theme to KSyntaxHighter to fix this basically.
Comment 5 Christoph Cullmann 2021-05-22 18:59:36 UTC 
If I not misunderstand the linked phabricator ticket (and that stuff linked there), this got now fixed in a different layer of the stack?