Bug 422476 - icon theme breaks delegate bounds
Summary: icon theme breaks delegate bounds
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-05 09:45 UTC by Harald Sitter
Modified: 2020-06-08 13:21 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.72


Attachments
screenshot (206.46 KB, image/png)
2020-06-05 09:45 UTC, Harald Sitter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2020-06-05 09:45:17 UTC
Created attachment 129064 [details]
screenshot

was casually browsing through icon themes when one of the themes managed to mess up the layout... see screenshot
This seems fairly reproducible with the data of the oranchelo icon theme

OBSERVED RESULT
delegate breaks out of frame

EXPECTED RESULT
all delegates are unfirom

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Kernel Version: 5.4.0-33-generic
OS Type: 64-bit
Processors: 12 × AMD Ryzen 5 3600X 6-Core Processor
Memory: 31,3 GiB of RAM
Graphics Processor: AMD Radeon RX 5700 XT 

ADDITIONAL INFORMATION
This happens on wayland with 2 screens and different scaling factors.
Comment 1 Dan Leinir Turthra Jensen 2020-06-05 11:25:34 UTC
Thanks for that - it's suboptimal, but it'll basically need an overall fix like the one in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/2 and then a per-entry handling, where we inform the content creator to maybe consider the way their content looks in KNS (which in many cases will be how their content will be consumed, and so i imagine they'll have some reasonable interest in not looking too broken there)
Comment 2 Dan Leinir Turthra Jensen 2020-06-08 08:35:48 UTC
Git commit a1cc382053837e0884603d05c98ac912a9e42415 by Dan Leinir Turthra Jensen.
Committed on 08/06/2020 at 08:35.
Pushed by leinir into branch 'master'.

Don't allow content to overflow in the grid delegates

Due to the content shown in the delegates being user created, we
cannot trust that it will flow correctly when shown inside a
Text (or Label) Component. Consequently, we have to deal with the
unfortunate cases where that content would end up overflowing.
While it is suboptimal to do this by just clipping it, it will
make the delegates look less broken, and we can then suggest
to the content creator to maybe consider the presentation
of their content in KNS as well as on the website.

M  +1    -0    src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M  +1    -0    src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

https://invent.kde.org/frameworks/knewstuff/commit/a1cc382053837e0884603d05c98ac912a9e42415