Bug 422468 - Tellico crash after quit
Summary: Tellico crash after quit
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 3.3.1
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-04 23:19 UTC by gitdevmod
Modified: 2021-03-03 13:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 3.4
Sentry Crash Report:


Attachments
gdb backtrace (11.71 KB, text/plain)
2020-06-04 23:19 UTC, gitdevmod
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gitdevmod 2020-06-04 23:19:36 UTC
Created attachment 129057 [details]
gdb backtrace

SUMMARY
Tellico compiled with kde-craft.Websearch with musicbrainz and discogs and save collection works as expected.

Tellico crash when I use 'file->close' or close button.

STEPS TO REPRODUCE
1. start tellico
2. search/add stuff/save
3. quit tellico

OBSERVED RESULT
Tellico crash and maybe it could probably corrupt collection

EXPECTED RESULT
No crash

SOFTWARE/OS VERSIONS
Windows: 10 1909
KDE Frameworks 5.69.0
Qt 5.14.1 (construit sur 5.14.1)
Le système de fenêtres windows

ADDITIONAL INFORMATION
Comment 1 gitdevmod 2020-06-06 23:09:46 UTC
I've build tellico with CMAKE_DISABLE_FIND_PACKAGE_KF5NewStuff=TRUE but it still crash.
Then I commented this line "NewStuff::Manager::self();" in src/mainwindow.cpp and no more crash after quit. I do not know impact of this change. 

According to kde-craft dev, there is patch in qt for dbus on Windows and it could crash.
Is this possible to add an option to disable dbus/knewstuff in tellico ?
Comment 2 Robby Stephenson 2020-06-09 01:09:41 UTC
(In reply to gitdevmod from comment #1)
> I've build tellico with CMAKE_DISABLE_FIND_PACKAGE_KF5NewStuff=TRUE but it
> still crash.
> Then I commented this line "NewStuff::Manager::self();" in
> src/mainwindow.cpp and no more crash after quit. I do not know impact of
> this change. 

It just removes the DBUS interface for installing new themes, which you would probably not even miss. I'm not sure why it would crash though

> According to kde-craft dev, there is patch in qt for dbus on Windows and it
> could crash.
> Is this possible to add an option to disable dbus/knewstuff in tellico ?

That might be the brute-force approach. I'll work it. Thanks for working that out.
Comment 3 Robby Stephenson 2021-03-03 12:16:53 UTC
Git commit abd4e2aa357fdbf0818f875a836a0f409fc075c1 by Robby Stephenson.
Committed on 03/03/2021 at 12:16.
Pushed by rstephenson into branch 'master'.

Check dbus interface pointer before unregistered

Try to avoid crash on windows

M  +5    -1    src/newstuff/manager.cpp

https://invent.kde.org/office/tellico/commit/abd4e2aa357fdbf0818f875a836a0f409fc075c1
Comment 4 Robby Stephenson 2021-03-03 13:50:06 UTC
From my basic test, I think the recent commit fixed the crashing bug.