Bug 422429 - Guides are always drag while editing
Summary: Guides are always drag while editing
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: Tool/Assistants (show other bugs)
Version: 4.3.0-beta2
Platform: Appimage Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-03 17:28 UTC by Olga Batalina
Modified: 2020-07-10 04:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Guides in Gimp and Krita differences (1.49 MB, video/matroska)
2020-06-05 11:40 UTC, Olga Batalina
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olga Batalina 2020-06-03 17:28:15 UTC
SUMMARY
When use a brush, line, curve either other tool with snapping to the guides, while guides are visible they are wants to be moved over the canvas, against snapping to it.

STEPS TO REPRODUCE
1. Set View->Snap->Snap to guides
2. Set View->Show guides
3. Add two or more guides
4. Select line tool
5. Try to draw a line with snapping to the guide

OBSERVED RESULT
Can't snap to the guide, selecting and move the guide otherwise.

EXPECTED RESULT
Guides must be moved only with move tool, like Adobe Photoshop or GIMP.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Dmitry Kazakov 2020-06-03 18:03:44 UTC
Hi, Olga!

Here is a special switch View->Lock Guides, which locks guides so they are not movable anymore. I guess it works the same way both, in PS and Gimp. Isn't it?
Comment 2 Olga Batalina 2020-06-05 11:40:53 UTC
Created attachment 129071 [details]
Guides in Gimp and Krita differences
Comment 3 Olga Batalina 2020-06-05 11:42:55 UTC
No, it's wrong. Tge existing guide most not interact with other tools than move tool, and intersection of guides must to be mover too, when selected with move tool (both intersected guides are moving).
Comment 4 Bug Janitor Service 2020-06-06 04:33:12 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 Ivan Batalin 2020-06-07 07:06:18 UTC
My vision of this problem, and several methods of solving for the best user experience, locking guides or switching to gimp/photoshops method are not correct by the Krita main ideology and design.

The issue appears when you working with all tools without left mouse button (stylus pressure or a finger touch event) pressed. In this case guide selects immediately and prevents to drawing at this place, even snap to this guide. The most awful UX example is drawing with Polyline, Polygon, or Bezier Curve tool.

There are three possible solutions to workaround this issue:
The first - we are may limit tools, that can select the guides for the moving purposes, for example Select shapes, Edit Shapes, Move and Zoom tools (such as Inkscape does).
The second - will be adding a small delay (for example 300ms) after activating guide in case of mouse hover event, but this solution are not perfect at all, and dissolves other user experience.
The third possible solution - to disable selecting guides when tool are in active state (in the process of drawing, or selecting next point) without left button pressed. This solution was solved issue, but not in the cases when you must start drawing with snapping to the guide. This method can be combined with the second solution for the best effort.

I may try to implement any of above solutions and contribute this patch to the upstream, if it will be needed by the developer community.

Best regards, Ivan Batalin.
Comment 6 Dmitry Kazakov 2020-06-10 09:09:53 UTC
Hi, Ivan!

I had a talk with Olga in VK and she said that "Lock Guides" option solves her problem. Is your comment still valid?

Concerning your proposals, I think it might be useful to limit guides modifications to the Shape Move tool only. Though this solution is rather disputable and we would have to ask painters if they want such behavior.

Technically, the relevant parts of the code are in:

1) KoRuler::mousePressEvent()
2) class KisGuidesManager
3) class DefaultTool

Here is the most up-to-date guide for building Krita on Windows:
https://invent.kde.org/snippets/877
Comment 7 Ivan Batalin 2020-06-10 09:59:24 UTC
Hi, Dmitry!

Yes this problem a take in place.
Thank you for hinting to code snippets for the review.

As at last 15yeas I was using Linux at home and work, I'll try to build Krita in chroot sandbox by the official documentation:
https://docs.krita.org/en/untranslatable_pages/building_krita.html
Comment 8 Dmitry Kazakov 2020-06-10 14:05:29 UTC
Hi, Ivan!

On Linux, if you have not-very-modern Intel GPU or NVidia GPU you can use the docker for building, it will save you a lot of time:

https://invent.kde.org/dkazakov/krita-docker-env

I will downgrade this bug to a wish:

WISHGROUP: Small Usability Fixes
Comment 9 Bug Janitor Service 2020-06-25 04:33:08 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2020-07-10 04:33:10 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!