Created attachment 129005 [details] A montage of two screenshot showing single column and overall view Hi, Issue: Under certain conditions the brush presets thumbnails are not squary anymore and looks like rectangles with the preview deformed (see screenshot in attachement). The easiest way to reproduce a case is by resizing the docker for a single column with a tag containing around 10 presets (quick loop animation https://www.peppercarrot.com/extras/temp/2020-06-02_nonsquary.gif ). Expected: I wish the thumbnails could keep their original square aspect ratio and not be deformed.
Is it a regression?
@dmitryk: from a IRC discussion this evening: [19:25] <Wolthera_laptop> well, that particular bug is dead as a doornail in 5.0 (because we just stopped using a tableview for resources choosers and are now using a listview). [...] [19:25] <Wolthera_laptop> the non-square is caused by the height of the rows somehow not being updated... but... we'd need to be able to reproduce for fixing in 4.3 [...] [19:26] <ivanyossi|log> deevad: with one row its intended [19:27] <Wolthera_laptop> o rly? [19:27] <ivanyossi|log> intentional* its coded like that, otherwise the square size is too big to show a meaningful number of presets [19:28] <Wolthera_laptop> what a surreal decision... [19:28] <ivanyossi|log> Wolthera_laptop: that how I interpreted the code since it was so weird to have such big presets, although it could be an accident I found useful (ugly, but useful :p) [19:29] <Wolthera_laptop> but I guess the 4.3 version is still trying to be a little too smart. [...] [19:30] <ivanyossi|log> Wolthera_laptop, deevad Should I go ahead and make it square always?? I think big presets could be better for touch based input [19:30] <Wolthera_laptop> yeah, for 4.3 [19:31] <Wolthera_laptop> for 5.0, we don't try to do any smart resizing atm. [...] [19:32] <ivanyossi|log> deevad: ok! I should do it then :D
Seems to be fixed in 778e9bd3a9d1ffbaa941cc9083957b8787e0ba4b.