Bug 422385 - Dolphin shows docker volumes in Devices section
Summary: Dolphin shows docker volumes in Devices section
Status: RESOLVED FIXED
Alias: None
Product: frameworks-solid
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.70.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Lukáš Tinkl
URL: https://www.reddit.com/r/kde/comments...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-02 18:08 UTC by gudvinr+kde
Modified: 2021-01-15 19:47 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.79


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gudvinr+kde 2020-06-02 18:08:52 UTC
SUMMARY

If storage driver in docker set to overlay2 and you have volumes in use, dolphin shows them.


STEPS TO REPRODUCE
0. Install docker
1. Ensure you have overlay2 storage driver set in docker
2. Create and mount volume

OBSERVED RESULT
Docker volumes are shown in devices section.

EXPECTED RESULT
Docker volumes shouldn't be shown in devices section since these are internal storage devices and aren't accessible.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Kernel Version: 5.4.43-1-lts
OS Type: 64-bit
Comment 1 Méven Car 2020-11-25 11:16:56 UTC
I believe this has been fixed, loop devices are excluded from the devices in the PlacePanel nowadays.

Please reopen if it is not the case.

*** This bug has been marked as a duplicate of bug 379516 ***
Comment 2 gudvinr+kde 2020-11-25 17:11:38 UTC
(In reply to Méven Car from comment #1)
> I believe this has been fixed, loop devices are excluded from the devices in
> the PlacePanel nowadays.

Fixed in which version? I am on 5.20.3/5.76.0 and docker overlays still there.
Comment 3 Méven Car 2020-11-25 21:11:50 UTC
All right as I said I was not sure it was still reproducible or not.
You versions should be recent enough that shouls have the fix I thought could fix this issue.

Could you paste here the return of `solid-hardware5 list` or `solid-hardware list` depending on which is available or your system ?
You can exclude the line that seem not to relate to your docker overlay mounts.

And if you could also `solid-hardware5 details udi` where udi is the value of your docker overlay udi returned by the first command.
Comment 4 gudvinr+kde 2020-11-25 22:33:27 UTC
(In reply to Méven Car from comment #3)
> And if you could also `solid-hardware5 details udi` where udi is the value
> of your docker overlay udi returned by the first command.

Now I have only one overlay from running container so that's it:

udi = '/org/kde/fstab/overlay/var/lib/docker/overlay2/3d557486b8f63fcdd70c697ef903bf849ccd9cc370f53df2deefad18b75e3dc2/merged'
  parent = '/org/kde/fstab'  (string)
  vendor = 'overlay'  (string)
  product = '/var/lib/docker/overlay2/3d557486b8f63fcdd70c697ef903bf849ccd9cc370f53df2deefad18b75e3dc2/merged'  (string)
  description = '/var/lib/docker/overlay2/3d557486b8f63fcdd70c697ef903bf849ccd9cc370f53df2deefad18b75e3dc2/merged (overlay)'  (string)
  icon = 'folder'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/var/lib/docker/overlay2/3d557486b8f63fcdd70c697ef903bf849ccd9cc370f53df2deefad18b75e3dc2/merged'  (string)
  StorageAccess.ignored = false  (bool)
Comment 5 Bug Janitor Service 2020-11-26 05:37:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/solid/-/merge_requests/23
Comment 6 Méven Car 2021-01-15 18:32:13 UTC
Git commit 4231d16822655da5a8f45c94414d5114386b2140 by Méven Car.
Committed on 15/01/2021 at 18:32.
Pushed by meven into branch 'master'.

[Fstab] Ignore docker overlay mounts

Overlay fs are ignored as long as they are not mounted at '/' i.e a
livesystem, or by the user.
FIXED-IN: 5.78

M  +14   -1    src/solid/devices/backends/fstab/fstabstorageaccess.cpp

https://invent.kde.org/frameworks/solid/commit/4231d16822655da5a8f45c94414d5114386b2140