Bug 422190 - Unreadable row under account details when Breeze Dark global theme is used
Summary: Unreadable row under account details when Breeze Dark global theme is used
Status: RESOLVED FIXED
Alias: None
Product: KAccounts
Classification: Frameworks and Libraries
Component: KCM (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 425314 428313 431575 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-28 16:15 UTC by Patrick Silva
Modified: 2021-01-14 12:11 UTC (History)
6 users (show)

See Also:
Latest Commit: https://invent.kde.org/network/kaccounts-integration/commit/41b91d296cfa139ba1f7ff1f985ca2e9ec62160e
Version Fixed In: 20.08.3
Sentry Crash Report:

Attachments
screenshot (89.50 KB, image/png)
2020-05-28 16:15 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-28 16:15:30 UTC 
Created attachment 128870 [details]
screenshot

STEPS TO REPRODUCE
1. set global theme to Breeze Dark
2. set an online account in Online Accounts kcm
3. open the datails of your online account

OBSERVED RESULT
see the attached screenshot.

EXPECTED RESULT
kcm should always be entirely readable

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Comment 1 Peter J. Mello 2020-06-08 05:29:56 UTC 
I'm experiencing precisely the same thing since adding the KDE Neon Git-Unstable repository to my Kubuntu 20.04 LTS system. Without sifting through the commit history yet, this smells like a regression.
Comment 2 Patrick Silva 2020-08-14 01:11:52 UTC 
*** Bug 425314 has been marked as a duplicate of this bug. ***
Comment 3 Bug Janitor Service 2020-08-14 09:13:02 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/kaccounts-integration/-/merge_requests/3
Comment 4 Dan Leinir Turthra Jensen 2020-08-14 17:29:34 UTC 
Git commit 6affdf9d5c406ac9cb17afb91c0278c9893c4e80 by Dan Leinir Turthra Jensen.
Committed on 14/08/2020 at 09:10.
Pushed by leinir into branch 'master'.

Fix account details page (especially on dark themes)

Not setting the colour of a rectangle yields a white one, never mind
what colorSet you set on it. Explicitly set the background colour to the
theme's background colour, so we don't end up with that nasty white
rectangle with some near-white text on top on dark themes.

M  +1    -0    src/kcm/package/contents/ui/AccountDetails.qml

https://invent.kde.org/network/kaccounts-integration/commit/6affdf9d5c406ac9cb17afb91c0278c9893c4e80
Comment 5 Patrick Silva 2020-10-26 15:50:36 UTC 
This bug is reproducible again when I use Breeze Dark global theme.

Operating System: Arch Linux
KDE Plasma Version: 5.20.1
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Comment 6 Nate Graham 2020-10-26 18:28:27 UTC 
Dan, can you investigate?
Comment 7 Nicolas Fella 2020-10-26 23:56:19 UTC 
Git commit 41b91d296cfa139ba1f7ff1f985ca2e9ec62160e by Nicolas Fella, on behalf of Dan Leinir Turthra Jensen.
Committed on 26/10/2020 at 23:55.
Pushed by nicolasfella into branch 'release/20.08'.

Fix account details page (especially on dark themes)

Not setting the colour of a rectangle yields a white one, never mind
what colorSet you set on it. Explicitly set the background colour to the
theme's background colour, so we don't end up with that nasty white
rectangle with some near-white text on top on dark themes.
(cherry picked from commit 6affdf9d5c406ac9cb17afb91c0278c9893c4e80)

M  +1    -0    src/kcm/package/contents/ui/AccountDetails.qml

https://invent.kde.org/network/kaccounts-integration/commit/41b91d296cfa139ba1f7ff1f985ca2e9ec62160e
Comment 8 Nicolas Fella 2020-10-26 23:58:31 UTC 
The fix was only in master, not 20.08.

I took the liberty of cherry-picking it https://invent.kde.org/network/kaccounts-integration/commit/41b91d296cfa139ba1f7ff1f985ca2e9ec62160e
Comment 9 Nate Graham 2020-10-27 01:20:19 UTC 
Thanks Nico!
Comment 10 Patrick Silva 2020-10-27 17:38:05 UTC 
*** Bug 428313 has been marked as a duplicate of this bug. ***
Comment 11 Nicolas Fella 2021-01-14 12:11:23 UTC 
*** Bug 431575 has been marked as a duplicate of this bug. ***