Bug 422178 - [ incremental save] Crash if filename already exist on disk
Summary: [ incremental save] Crash if filename already exist on disk
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (show other bugs)
Version: 4.3.0-beta1
Platform: Appimage Linux
: NOR crash
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-28 13:50 UTC by David REVOY
Modified: 2020-05-29 10:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2020-05-28 13:50:05 UTC
A crash that I can reproduce only with krita-4.3.0-beta1-c16cf7c-x86_64.appimage ; an appimage Dimitry produced for me to test the fix for the stabilizer last week. I can't reproduce in 4.2.9appimage or 4.3beta1appimage. So, feel free to close this bug if it is invalid, but I prefer to report it in case this is a new behavior appearing on 4.3beta bug fixes period:

STEPS TO REPRODUCE
1. Draw something with Krita and save it to test.kra on your disk
2. On your filemanager, rename test.kra to test_000.kra
3. Go back to Krita, and do File > Save incremental version

OBSERVED RESULT
Krita crash.

EXPECTED RESULT
Incremental save should have detected test_000.kra already exist and save to  test_001.kra.

Linux/KDE Plasma: Kubuntu Linux 19.10
Comment 1 Halla Rempt 2020-05-28 14:06:11 UTC
Strange that it should crash, though. If you start krita from the terminal, do you get a message about an assert?
Comment 2 David REVOY 2020-05-28 15:44:14 UTC
I have: 

 ~/sources/krita »»» ./krita-4.3.0-beta1-c16cf7c-x86_64.appimage 
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
QObject::startTimer: Timers cannot have negative intervals
Could not find platform independent libraries <prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
/tmp/.mount_krita-XBLHLm/usr/lib/krita-python-libs/krita added to PYTHONPATH
QObject::connect: Cannot connect (null)::stateChanged(QScroller::State) to KoToolBoxScrollArea::slotScrollerStateChange(QScroller::State)
QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout
ASSERT (krita): "job.isValid()" in file /home/appimage/workspace/Krita_Stable_Appimage_Build/krita/libs/ui/KisDocument.cpp, line 986
Aborted
Comment 3 Halla Rempt 2020-05-29 09:22:09 UTC
Git commit 69d735a1758122dad8d4651b5085ea8708433ca1 by Boudewijn Rempt.
Committed on 29/05/2020 at 09:21.
Pushed by rempt into branch 'krita/4.3'.

Correctly check whether the filename already exists when saving incremental

M  +1    -1    libs/ui/KisViewManager.cpp

https://invent.kde.org/graphics/krita/commit/69d735a1758122dad8d4651b5085ea8708433ca1
Comment 4 Halla Rempt 2020-05-29 09:22:22 UTC
Git commit 26b981aa452d24142f577ae00921933dca75705f by Boudewijn Rempt.
Committed on 29/05/2020 at 09:22.
Pushed by rempt into branch 'master'.

Correctly check whether the filename already exists when saving incremental
(cherry picked from commit 69d735a1758122dad8d4651b5085ea8708433ca1)

M  +1    -1    libs/ui/KisViewManager.cpp

https://invent.kde.org/graphics/krita/commit/26b981aa452d24142f577ae00921933dca75705f
Comment 5 David REVOY 2020-05-29 10:24:41 UTC
Thanks Boud!