Bug 422086 - Brush preset incorrectly marked as changed when changing tools
Summary: Brush preset incorrectly marked as changed when changing tools
Status: RESOLVED DUPLICATE of bug 430168
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 4.3.0-beta1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-26 09:04 UTC by Tyson Tan
Modified: 2021-09-07 09:44 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
No Problem Video (1.76 MB, video/mp4)
2020-05-28 18:22 UTC, Ahab Greybeard
Details
No Problem kritarc (74.78 KB, text/plain)
2020-05-28 18:23 UTC, Ahab Greybeard
Details
Some Problem video (2.05 MB, video/mp4)
2020-05-28 18:24 UTC, Ahab Greybeard
Details
Some Problem Fresh kritarc (13.34 KB, text/plain)
2020-05-28 18:24 UTC, Ahab Greybeard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2020-05-26 09:04:59 UTC
The Brush editor panel (F5) will display a warning icon to indicate the current preset's settings got changed. 

However, without actually changing anything in F5 panel, by just switching to another tool in Toolbox, F5 panel will still display the warning icon.

Although I don't use brush editor much often so I never noticed this issue, some users found it very confusing so they reported it to me and I relay it here.
Comment 1 wolthera 2020-05-26 09:05:45 UTC
Probably caused by tools having their own opacity these days.
Comment 2 Ahab Greybeard 2020-05-27 11:15:42 UTC
The opacity change related effect happens in 4.2.9. If you switch to a different painting tool (e.g Line Tool) and change the Opacity slider on the Toolbar.
From that point on, every time you use the Freehand Brush after using the line tool then it will indicate that the settings were changed, even though they have not for the Freehand Brush tool.

The same applies to all other painting tools.

Is that what is happening?
Comment 3 Tyson Tan 2020-05-27 12:10:12 UTC
Probably not. Krita will mark the preset as "changed" when I switched to Shape Select Tool which has nothing to do with opacity.
Comment 4 Ahab Greybeard 2020-05-27 12:40:31 UTC
This is strange because I don't see that happen when switching to the Shape Select Tool, or any other non-painting tool.

With the 4.3.0 beta-1 appimage, I've tried various combinations of actions and I can't induce a 'preset change' warning icon in the brush editor (unless I do the opacity variation thing with a different painting tool).
Comment 5 Tyson Tan 2020-05-28 16:07:15 UTC
1) Choose "Freehand Brush Tool"
2) Click "Reload the Brush Preset" button to make sure the "Changed" icon is cleared.
3) Choose "Basic 5 Size" brush preset
4) Press F5 to open Brush Editor, make sure it's not marked.
5) Choose "Select Shapes Tool"
6) Choose "Freehand Brush Tool"
7) Press F5 again to see whether it's marked as "changed"

To me and many others from the community, it's marked as "changed" every time. In one case, I didn't have to switch tools, the F5 panel marked the current preset as "changed" without me doing anything.
Comment 6 Ahab Greybeard 2020-05-28 18:22:52 UTC
Created attachment 128872 [details]
No Problem Video

Screen video showing no problem
Comment 7 Ahab Greybeard 2020-05-28 18:23:34 UTC
Created attachment 128873 [details]
No Problem kritarc
Comment 8 Ahab Greybeard 2020-05-28 18:24:11 UTC
Created attachment 128874 [details]
Some Problem video
Comment 9 Ahab Greybeard 2020-05-28 18:24:40 UTC
Created attachment 128875 [details]
Some Problem Fresh kritarc
Comment 10 Ahab Greybeard 2020-05-28 18:29:27 UTC
I don't see this, normally, but I do see it if I use a fresh kritarc file.
It also happens with the 4.2.9 appimage with a fresh kritarc file.

I've attached videos and the corresponding kritarc files for each situation.

With the fresh kritarc, the last used brush preset is immediately marked as having changed status as soon as a new file is made.

I not sure if anyone would be able to go through the kritarc files looking for significant differences.

Setting to Confirmed
Comment 11 Tiar 2021-03-22 23:46:49 UTC
There is bug 430168 which seems to be related, if not a duplicate. Both reports have lots of information and slightly so I'm not sure if I should mark one as duplicate and if so, which one.
Comment 12 Halla Rempt 2021-09-07 09:44:43 UTC

*** This bug has been marked as a duplicate of bug 430168 ***