Bug 422048 - When Breeze Dark global theme is used, white squares appear immediately before the preview of the addons to be loaded
Summary: When Breeze Dark global theme is used, white squares appear immediately befor...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-25 11:44 UTC by Patrick Silva
Modified: 2020-06-12 15:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screen recording (1.39 MB, video/webm)
2020-05-25 11:44 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-25 11:44:21 UTC
Created attachment 128765 [details]
screen recording

STEPS TO REPRODUCE
1. set global theme to Breeze Dark in system settings
2. open any "Get new <addon>" window
3. 

OBSERVED RESULT
We can see white squares immediately before the preview of the addons to be loaded.
See the attached screen recording please.

EXPECTED RESULT
No white square should appear.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-06-10 21:47:36 UTC
Can reproduce. This is probably the default/placeholder image loading before the real image is displayed. it's not visible with the default color scheme since it's the same color as the background, but you'll see it when using a colorscheme in which the view background isn't white. We should suppress this image.
Comment 2 Dan Leinir Turthra Jensen 2020-06-12 09:11:24 UTC
(In reply to Nate Graham from comment #1)
> This is probably the default/placeholder image loading before
> the real image is displayed.

  Turns out to be the shadowed rectangle sat behind the thumbnail - should be easy enough to sort out, just needs hiding when the image isn't loaded yet :) (which really it wants to be anyway)
Comment 3 Dan Leinir Turthra Jensen 2020-06-12 09:34:50 UTC
Yup, that was it - suggested fix at https://invent.kde.org/frameworks/knewstuff/-/merge_requests/3 :)
Comment 4 Dan Leinir Turthra Jensen 2020-06-12 15:28:48 UTC
Git commit 087cf5c476c09bbf3a5f2b7bd57171a3386001ca by Dan Leinir Turthra Jensen.
Committed on 12/06/2020 at 09:31.
Pushed by leinir into branch 'master'.

Hide the ShadowRectangle for non-loaded previews

This ommission is exposed when these views are used with a dark colour
scheme, as shown in the bug report https://bugs.kde.org/show_bug.cgi?id=422048

M  +1    -0    src/qtquick/qml/private/EntryScreenshots.qml
M  +1    -0    src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M  +1    -0    src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

https://invent.kde.org/frameworks/knewstuff/commit/087cf5c476c09bbf3a5f2b7bd57171a3386001ca