SUMMARY When do not disturb is turned on, the text displayed for the end date uses unusual capitalization and sometimes reads awkwardly. STEPS TO REPRODUCE 1. Turn on do not disturb for any length of time (other than "until turned off"). 2. Observe the label stating the do not disturb end date. OBSERVED RESULT The labels that each option ("for 1 hour", "for 4 hours", etc.) produces are as follows at the time of writing: - Until Today, 11:54 AM - Until Today, 2:54 PM - Until Today, 8:00 PM - Until Tomorrow, 6:00 AM - Until In two days, 6:00 AM EXPECTED RESULT I wouldn't expect: - the second word of the labels to be capitalized - the wording "until in [X] days", since it sounds unnatural. I would suggest "until [X] days from now" - the inclusion of the word "today" (because when one says e.g. "until 5:00 PM", the "today" is already implied) Example after making these three changes: - Until 11:54 AM - Until 2:54 PM - Until 8:00 PM - Until tomorrow, 6:00 AM - Until two days from now, 6:00 AM SOFTWARE/OS VERSIONS OS: Kubuntu 20.04 KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.68.0 Qt Version: 5.12.8
Created attachment 128730 [details] screenshot showing do not disturb end date of "Until In two days, 6:00 AM"
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1412
Git commit ce63606d42bb6324136763efbc91d03691bbfb01 by Nate Graham. Committed on 15/10/2022 at 18:06. Pushed by ngraham into branch 'master'. applets/notification: improve DND mode explanatory text This text suffered from two issues: - By trying to generate an English sentence, it became a string puzzle because not all possible relative date strings would work after the word "until". For example, "Until In two days" would be wrong. - It used inappropriate capitalization of the date despite trying to be in a sentence. This commit fixes both issues by splitting the two parts of the text on either side of a colon, creating a logical break between them. FIXED-IN: 5.27 M +3 -2 applets/notifications/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/ce63606d42bb6324136763efbc91d03691bbfb01