Bug 421921 - MacOS X builds failing on CI due to signing tool not liking plugin names
Summary: MacOS X builds failing on CI due to signing tool not liking plugin names
Status: REPORTED
Alias: None
Product: Craft
Classification: Developer tools
Component: Core (show other bugs)
Version: unspecified
Platform: unspecified macOS
: NOR normal
Target Milestone: ---
Assignee: Hannah von Reth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-22 15:48 UTC by michael
Modified: 2020-05-25 00:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description michael 2020-05-22 15:48:21 UTC 
SUMMARY

KDiff3 on binary-factory is currently failing on OS X with the fallowing.

00:44:13 error:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolch=
ain/usr/bin/install_name_tool: for:
/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/kd=
iff3/image-RelWithDebInfo-master/Users/packaging/Craft/BinaryFactory/macos-=
64-clang/plugins/kf5/parts/kdiff3part.so (for architecture x86_64) option
"-add_rpath /Users/packaging/Craft/BinaryFactory/macos-64-clang/lib" would
duplicate path, file already has LC_RPATH for:
/Users/packaging/Craft/BinaryFactory/macos-64-clang/lib

Errors of this sort appear in other projects as well. Unfortunately I don't have the ability to do local testing of MacOS X craft builds. For KDiff3 I can work around this by not generating the shared lib which is only really needed as on linux/KDE platforms. My research on this issue indicates it is a compatibility issue between -rpath and certain versions of apples tool chain.
Comment 1 Hannah von Reth 2020-05-22 21:50:34 UTC 
The error is:

01:47:12  executing command: /usr/bin/codesign --keychain /Users/packaging/Library/Keychains/login.keychain --sign Developer ID Application: K Desktop Environment e.V. (5433B4KXM8) --force --preserve-metadata=entitlements --options runtime --verbose=99 --deep /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/kdiff3/archive/Applications/KDE/kdiff3.app
01:47:32  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/kdiff3/archive/Applications/KDE/kdiff3.app: bundle format unrecognized, invalid, or unsuitable
01:47:32  In subcomponent: /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/kdiff3/archive/Applications/KDE/kdiff3.app/Contents/PlugIns/kf5/org.kde.kwindowsystem.platforms
Comment 3 michael 2020-05-22 22:01:55 UTC 
I'll go ahead and try the work around you suggested but if you look at https://binary-factory.kde.org/job/KDiff3_Nightly_macos/105/consoleFull
The error I mentioned precedes the signing fail. Could please clarify why it is not the root cause?
Comment 4 michael 2020-05-25 00:20:14 UTC 
That got it working. Would be nice to have this documented.