SUMMARY It happens with the 4.3.0 beta too. STEPS TO REPRODUCE 1 Load any image 2 Select an area with contiguous selection tool > erase 3 Repeat step 2 multiple times, and try to get back where you started using undo function The result : Some areas is gonna remain empty and not get restored, as if that part of the data is permanently gone. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
I confirm, I can reproduce in Git~c16cf7c (4.3'nightly'appimage) on Kubuntu Linux 19.10. I had to do 5x [contiguous selections + erase with delete], the two first couldn't be undone and colors selected are erased for good.
I'm not sure it's a tool-specific issue, but I haven't been able to find other tools or functions have this issue with undo.
Hi, acc4commissions and David! Could you please check if this package fixes the problem for you? https://yadi.sk/d/PkqBBYdP8urX4g
(In reply to Dmitry Kazakov from comment #3) > Hi, acc4commissions and David! > > Could you please check if this package fixes the problem for you? > https://yadi.sk/d/PkqBBYdP8urX4g I want to test but my OS is Windows, not Linux.
I can still reproduce @dmitryk with the build (thanks for the appimage). I took the contiguous selection tool on a flat artwork, and selected areas of colors then deleted them with delete key immediately (repeated it for 5 or 6 area), then I tried to undo them one by one and redo. I has a lot of glitch, missing redo, missing undos.
Video (1minute, webm, 9MB) of the bug: https://www.peppercarrot.com/extras/temp/2020-05-30_undo-contiguous-bug.webm
Okay, the bug seem to be reproducible in 4.3 branch, but is not reproducible in master. My vector selections undo patchset does **not** fix the issue (https://invent.kde.org/graphics/krita/-/merge_requests/351). Probably, it was fixed in master by some other "dangerous" patchset that was not backported.
The bug was fixed in the commit listed below. I have cherry-picked that to 4.3.1 branch. commit 10cad8b7a4721b33c98923beb354e5457b5cc48d (HEAD) Author: Dmitry Kazakov <dimula73@gmail.com> Date: Fri May 1 17:24:54 2020 +0300 [NOT FOR 4.3.0] Remove start position from KisRandomAccessor2 Start posiiton in ctor is not used anywhere, it only causes bugs like 395861, because some code passes default value (0,0) to it, which extends extent of the paint device, to the area, which is not actually modified. It might also fix some troubles with Transform Tool (not tested). CCBUG:395861