Bug 421906 - Wrong tab colors after session restore
Summary: Wrong tab colors after session restore
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-22 11:15 UTC by Andreas Hartmetz
Modified: 2020-05-22 23:06 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Tab color settings page for affected session (82.95 KB, image/png)
2020-05-22 11:15 UTC, Andreas Hartmetz
Details
Three restored and three newly opened tabs (27.04 KB, image/png)
2020-05-22 11:21 UTC, Andreas Hartmetz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Hartmetz 2020-05-22 11:15:40 UTC
Created attachment 128686 [details]
Tab color settings page for affected session

SUMMARY
Wrong tab colors after session restore

STEPS TO REPRODUCE
1. Open Konsole with any number of tabs (I have six)
2. End Plasma session (for me: shut down the computer)
3. Start new Plasma session (for me: turn on the computer)

OBSERVED RESULT
The color bar on the restored tabs is black

EXPECTED RESULT
The color bar on the tabs is light gray (application background color) - which is also the color of newly opened tabs (I use Ctrl-Shift-T).

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: master as of today
(available in About System)
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: compiled from sources, 5.14 branch (may be a few weeks old, almost nothing changed anyway)

ADDITIONAL INFORMATION
This might be a problem only with old Konsole configuration (Gustavo who did the tab color features might have deleted configuration several times during development, that is how it usually goes). The tab color setting in settings looks strange for me. See screenshot. The text says "user defined" in English.
Comment 1 Andreas Hartmetz 2020-05-22 11:21:10 UTC
Created attachment 128687 [details]
Three restored and three newly opened tabs

By logging out and back into a session, in which Konsole was open with three tabs, I got three restored tabs. Then I opened three new tabs with Ctrl-Shift-T. Observe the difference in tab color.
Comment 2 Gustavo Carneiro 2020-05-22 15:09:34 UTC
Bug Fixed in PR: https://invent.kde.org/utilities/konsole/-/merge_requests/101
Comment 3 Nate Graham 2020-05-22 15:10:30 UTC
But the merge request hasn't been merged yet.
Comment 4 Gustavo Carneiro 2020-05-22 15:24:50 UTC
Sorry, I don't have permission yet :(
Comment 5 Nate Graham 2020-05-22 15:31:28 UTC
Yes, it needs to be reviewed first, and then merged. Only at that point does the bug report get closed. :)
Comment 6 Gustavo Carneiro 2020-05-22 20:22:20 UTC
There, it's revised and merged!
Comment 7 Andreas Hartmetz 2020-05-22 22:19:24 UTC
Great job, thanks for fixing it so quickly!
Comment 8 Gustavo Carneiro 2020-05-22 23:06:13 UTC
I thank you for reporting :)