Bug 421744 - Preserve the color of the layer label in layers docker when merging others to it
Summary: Preserve the color of the layer label in layers docker when merging others to it
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-18 21:36 UTC by acc4commissions
Modified: 2020-08-13 19:32 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2020-05-18 21:36:04 UTC
SUMMARY
The title says it all. Versions doesn't seem relevant.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Tiar 2020-05-18 21:47:46 UTC
You mean the color label of the layer? The one that you choose in right-click and then you can filter by it? (And now also fill or use the magic wand tool).
Comment 2 acc4commissions 2020-05-18 22:00:40 UTC
(In reply to Tymond from comment #1)
> You mean the color label of the layer? The one that you choose in
> right-click and then you can filter by it? (And now also fill or use the
> magic wand tool).

Yes, the color label. I'm not sure what you meant by the fill and the magic wand though.
Comment 3 Bug Janitor Service 2020-05-19 04:33:25 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Lynx3d 2020-05-19 06:09:38 UTC
I noticed it too, I decided to finally use color labels on my last project too, only to find out they're rather annoying because they reset every time you merge something in...
Same thing happens with active channels btw, I've complained about it before, and was told it's supposed to be like that.

Color labels also get reset when flattening a layer with masks btw, although ironically that does not reset active channels, but it bakes in opacity, so I don't see a consistent patter here, you need to know a lot of quirks for proper layer usage.
Comment 5 Dmitry Kazakov 2020-08-13 18:50:38 UTC
Hi, Lynx3D!

The idea of merging channel flags, opacity and blending mode is the following:

1) If all three coincide, then we merge the two layers using Normal blending mode and set channel flags, opacity and blending mode of the original layers.

2) If at least one of the properties differ, then we create a clean new layer with default properties and just merge in both layers using their settings.

The idea of the approach is that we preserve the visual look of the image as much as possible. If you have ideas how to improve that, please ping me on IRC
Comment 6 Dmitry Kazakov 2020-08-13 19:27:31 UTC
Git commit 64e870a3af369ac50577615b48a480c02fc12c75 by Dmitry Kazakov.
Committed on 13/08/2020 at 19:25.
Pushed by dkazakov into branch 'krita/4.3'.

Fix the color label of the layers when doing merge-down

The final layer should have the label of the lowest
selected layer.

M  +4    -1    libs/image/kis_layer_utils.cpp

https://invent.kde.org/graphics/krita/commit/64e870a3af369ac50577615b48a480c02fc12c75
Comment 7 Dmitry Kazakov 2020-08-13 19:32:39 UTC
Git commit f224c11c4520a6fb3158ef594bce55000900c561 by Dmitry Kazakov.
Committed on 13/08/2020 at 19:30.
Pushed by dkazakov into branch 'master'.

Fix the color label of the layers when doing merge-down

The final layer should have the label of the lowest
selected layer.

# Conflicts:
#	libs/image/kis_layer_utils.cpp

M  +4    -1    libs/image/kis_layer_utils.cpp

https://invent.kde.org/graphics/krita/commit/f224c11c4520a6fb3158ef594bce55000900c561