Bug 421629 - Tab navigation order in properties windows is not logical
Summary: Tab navigation order in properties windows is not logical
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.2.9
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Tiar
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2020-05-16 17:38 UTC by EosEtIris
Modified: 2021-08-23 08:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description EosEtIris 2020-05-16 17:38:01 UTC
SUMMARY
When navigating through the different properties in a properties window using the TAB key.

STEPS TO REPRODUCE
1. Open a properties window. ("Filter Mask Properties" is where I discovered it first)
2. Click into any property and then press TAB
3. See if the property in focus is the one you expected to be next
4. Repeat step 2-3 until you have navigated all the properties.

OBSERVED RESULT
In "Filter Mask Properties" the option focus order is as follows:
1. Layer name
2. Type
3. Colorize
4. Hue (slider)
5. Saturation (spinner)
6. Saturation (slider)
7. Lightness (slider)
8. Lightness (spinner)
9. Hue (spinner)
10. Reset
11. OK
12. Cancel

EXPECTED RESULT
For "Filter Mask Properties"
1. Layer name
2. Type
3. Hue (slider)
4. Hue (spinner)
5. Saturation (slider)
6. Saturation (spinner)
7. Lightness (slider)
8. Lightness (spinner)
9. Colorize
10. Reset
11. OK
12. Cancel


SOFTWARE/OS VERSIONS
Windows: 10

ADDITIONAL INFORMATION
This is not only the case for "Filter Mask Properties" a similar bonkers navigation order is present in "Layer Properties".
Comment 1 Tiar 2020-08-04 14:05:27 UTC
Note: How to access it: Create a mask, right-click, select "Properties...", click the name field, then press Tab a few times.
The Layer Properties are less insane than the mask ones.
Confirming.
Comment 2 Tiar 2021-08-16 18:29:23 UTC
The layers dialog now doesn't prevent the user from using the canvas, so using Tab only gets me to the Canvas-only mode...
Comment 3 Tiar 2021-08-22 22:50:13 UTC
Git commit 4826656afce8b608bd3cec2de7126405aa93d087 by Agata Cacko.
Committed on 22/08/2021 at 22:49.
Pushed by tymond into branch 'master'.

Fix tab order in HSV Adjustments Filter widget

Before this commit, the tab order in HSV Adjustment Filter widget
was very incorrect and looked random. This commit adds the specfic
order to the .ui file so now the order is correct.

M  +8    -0    plugins/filters/colorsfilters/wdg_hsv_adjustment.ui

https://invent.kde.org/graphics/krita/commit/4826656afce8b608bd3cec2de7126405aa93d087
Comment 4 Halla Rempt 2021-08-23 08:57:49 UTC
Git commit 3de6cffc0e0751a70b084b91954aaca5dc0522af by Halla Rempt, on behalf of Agata Cacko.
Committed on 23/08/2021 at 08:57.
Pushed by rempt into branch 'krita/5.0'.

Fix tab order in HSV Adjustments Filter widget

Before this commit, the tab order in HSV Adjustment Filter widget
was very incorrect and looked random. This commit adds the specfic
order to the .ui file so now the order is correct.
(cherry picked from commit 4826656afce8b608bd3cec2de7126405aa93d087)

M  +8    -0    plugins/filters/colorsfilters/wdg_hsv_adjustment.ui

https://invent.kde.org/graphics/krita/commit/3de6cffc0e0751a70b084b91954aaca5dc0522af