Bug 421571 - With fractional scale factor, Toolbars have the wrong color except on the About and Application page
Summary: With fractional scale factor, Toolbars have the wrong color except on the Abo...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: 5.18.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-15 15:28 UTC by Nate Graham
Modified: 2020-05-18 16:24 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/commit/aa2e322156266b4169ed23c63c81a81671a616a3
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Featured page: wrong color (120.52 KB, image/png)
2020-05-15 15:28 UTC, Nate Graham 		Details
About page: correct (121.13 KB, image/png)
2020-05-15 15:28 UTC, Nate Graham 		Details
Updates page: wrong color (124.30 KB, image/png)
2020-05-15 15:29 UTC, Nate Graham 		Details
Application page: correct (118.56 KB, image/png)
2020-05-15 15:29 UTC, Nate Graham 		Details
Settings page: wrong color (130.75 KB, image/png)
2020-05-15 15:29 UTC, Nate Graham 		Details
Installed page: wrong color (121.59 KB, image/png)
2020-05-15 15:30 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-05-15 15:28:29 UTC 
Created attachment 128480 [details]
Featured page: wrong color

When I use a 125% scale factor in the KScreen KCM (and reboot), all of Discover's pages with toolbars display the wrong color for those toolbars--except for the About and Application pages. (which display the correct color). See attached screenshots.
Comment 1 Nate Graham 2020-05-15 15:28:56 UTC 
Created attachment 128481 [details]
About page: correct
Comment 2 Nate Graham 2020-05-15 15:29:22 UTC 
Created attachment 128482 [details]
Updates page: wrong color
Comment 3 Nate Graham 2020-05-15 15:29:38 UTC 
Created attachment 128483 [details]
Application page: correct
Comment 4 Nate Graham 2020-05-15 15:29:53 UTC 
Created attachment 128484 [details]
Settings page: wrong color
Comment 5 Nate Graham 2020-05-15 15:30:09 UTC 
Created attachment 128485 [details]
Installed page: wrong color
Comment 6 Nate Graham 2020-05-15 15:52:03 UTC 
I cannot reproduce the issue in Kirigami Gallery, FWIW.
Comment 7 Nate Graham 2020-05-15 17:47:01 UTC 
Fixed with and https://phabricator.kde.org/D29784 https://phabricator.kde.org/D29785
Comment 8 Aleix Pol 2020-05-18 16:24:49 UTC 
Git commit aa2e322156266b4169ed23c63c81a81671a616a3 by Aleix Pol.
Committed on 18/05/2020 at 16:24.
Pushed by apol into branch 'Plasma/5.19'.

Hardcode fewer colorSets

Summary:
We were overriding them on the background only and it would play weird with the
feature where the toolbar looks the same as the page.

Test Plan: Still feels a bit random that it keeps changing but at least it looks consistent.

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29784

M  +0    -5    discover/qml/ApplicationsListPage.qml
M  +0    -6    discover/qml/BrowsingPage.qml
M  +0    -6    discover/qml/SourcesPage.qml
M  +0    -2    discover/qml/UpdatesPage.qml

https://invent.kde.org/plasma/discover/commit/aa2e322156266b4169ed23c63c81a81671a616a3