Bug 421434 - smb4k crashed in Breeze::ShadowHelper::~ShadowHelper() when closed with ctrl+q
Summary: smb4k crashed in Breeze::ShadowHelper::~ShadowHelper() when closed with ctrl+q
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords: drkonqi
: 419486 422568 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-12 21:46 UTC by Patrick Silva
Modified: 2020-07-30 15:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-12 21:46:16 UTC
Application: smb4k (3.0.70)

Qt Version: 5.14.2
Frameworks Version: 5.71.0
Operating System: Linux 5.3.0-45-generic x86_64
Windowing system: X11
Distribution: KDE neon Unstable Edition

-- Information about the crash:
- What I was doing when the application crashed:
smb4k was minimized in systray, I changed display scale to 150% in system settings > display configuration,
I unminimized smb4k by clicking on its hidden systray icon and closed it by pressing ctrl+q.
Plasma shown crash notification.

The crash does not seem to be reproducible.

-- Backtrace:
Application: Smb4K (smb4k), signal: Segmentation fault
Content of s_kcrashErrorMessage: [Current thread is 1 (Thread 0x7f283f73ed80 (LWP 12628))]
[KCrash Handler]
#6  0x00007f2816d43a8c in qDeleteAll<QMap<QWidget*, KWindowShadow*>::const_iterator> (end=..., begin=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qalgorithms.h:320
#7  qDeleteAll<QMap<QWidget*, KWindowShadow*> > (c=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qalgorithms.h:328
#8  Breeze::ShadowHelper::~ShadowHelper (this=0x55accb13ea10, __in_chrg=<optimized out>) at ./kstyle/breezeshadowhelper.cpp:105
#9  0x00007f2816d43bb9 in Breeze::ShadowHelper::~ShadowHelper (this=0x55accb13ea10, __in_chrg=<optimized out>) at ./kstyle/breezeshadowhelper.cpp:106
#10 0x00007f2816d52786 in Breeze::Style::~Style (this=0x55accb19c1a0, __in_chrg=<optimized out>) at ./kstyle/breezestyle.cpp:200
#11 0x00007f2816d52849 in Breeze::Style::~Style (this=0x55accb19c1a0, __in_chrg=<optimized out>) at ./kstyle/breezestyle.cpp:202
#12 0x00007f283d00e2f9 in QApplication::~QApplication (this=0x7ffc9f274cb0, __in_chrg=<optimized out>) at kernel/qapplication.cpp:812
#13 0x000055accacbf1f5 in main (argc=<optimized out>, argv=<optimized out>) at ./smb4k/main.cpp:146

Possible duplicates by query: bug 421077, bug 420495, bug 420414, bug 420134, bug 419798.

Reported using DrKonqi
Comment 1 Patrick Silva 2020-05-12 22:28:56 UTC
steps to reproduce:
open smb4k
press ctrl+o
cancel "Mount share" window
press ctrl+q
Comment 2 Alexander Reinholdt 2020-05-18 04:48:36 UTC
Thank you for reporting this issue. 

I tried to reproduce your problem on a KDE neon User and on a Kubuntu 20.04 system. However, I wasn't successful. Is the problem still occurring?
Comment 3 Patrick Silva 2020-05-20 20:24:54 UTC
yes, it's still happening.
The backtrace is similar to the one of bug 419486.
Comment 4 Alexander Reinholdt 2020-05-21 04:36:53 UTC
Looking at the backtrace, I get the impression that the crash happens in Breeze, but not in Smb4K. So, I will forward this bug.
Comment 5 Wolfgang Bauer 2020-06-12 10:36:55 UTC
*** Bug 422568 has been marked as a duplicate of this bug. ***
Comment 6 Wolfgang Bauer 2020-06-12 10:52:50 UTC
FTR, the same crash happens with Oxygen as well:
Application: Smb4K (smb4k), signal: Segmentation fault

[KCrash Handler]
#4  0x00007ff5700b1404 in qDeleteAll<QMap<QWidget*, KWindowShadow*>::const_iterator> (end=..., begin=...) at /usr/include/qt5/QtCore/qalgorithms.h:320
#5  qDeleteAll<QMap<QWidget*, KWindowShadow*> > (c=...) at /usr/include/qt5/QtCore/qalgorithms.h:328
#6  Oxygen::ShadowHelper::~ShadowHelper (this=0x559f2eee5ca0, __in_chrg=<optimized out>) at /usr/src/debug/oxygen5-5.19.0-lp151.265.1.x86_64/kstyle/oxygenshadowhelper.cpp:58
#7  0x00007ff5700b17b9 in Oxygen::ShadowHelper::~ShadowHelper (this=0x559f2eee5ca0, __in_chrg=<optimized out>) at /usr/src/debug/oxygen5-5.19.0-lp151.265.1.x86_64/kstyle/oxygenshadowhelper.cpp:61
#8  0x00007ff5700b9481 in Oxygen::Style::~Style (this=0x559f2eee7000, __in_chrg=<optimized out>) at /usr/src/debug/oxygen5-5.19.0-lp151.265.1.x86_64/kstyle/oxygenstyle.cpp:269
#9  0x00007ff5700b94b9 in Oxygen::Style::~Style (this=0x559f2eee7000, __in_chrg=<optimized out>) at /usr/src/debug/oxygen5-5.19.0-lp151.265.1.x86_64/kstyle/oxygenstyle.cpp:271
#10 0x00007ff590b9cc17 in QApplication::~QApplication (this=0x7fffecb2d640, __in_chrg=<optimized out>) at kernel/qapplication.cpp:746
#11 0x0000559f2d1e35b5 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/smb4k-3.0.6-lp151.22.2.x86_64/smb4k/main.cpp:145
[Inferior 1 (process 8178) detached]

(that's with Qt 5.15.0, KDE Frameworks 5.70.0 and Plasma 5.19.0)
Comment 7 Vlad Zahorodnii 2020-06-12 11:30:24 UTC
*** Bug 419486 has been marked as a duplicate of this bug. ***
Comment 8 Vlad Zahorodnii 2020-06-12 11:32:04 UTC
This crash should be fixed in the final release of 5.19.

> FTR, the same crash happens with Oxygen as well:

Unfortunately, nobody has volunteered to review the fix. https://invent.kde.org/plasma/oxygen/-/merge_requests/1
Comment 9 Wolfgang Bauer 2020-06-12 12:48:14 UTC
(In reply to Vlad Zahorodnii from comment #8)
> This crash should be fixed in the final release of 5.19.
Indeed, I cannot reproduce it with Breeze anymore.

> > FTR, the same crash happens with Oxygen as well:
> 
> Unfortunately, nobody has volunteered to review the fix.
> https://invent.kde.org/plasma/oxygen/-/merge_requests/1

I'll test it in a minute.
Comment 10 Patrick Silva 2020-07-23 13:06:43 UTC
(In reply to Patrick Silva from comment #1)
> steps to reproduce:
> open smb4k
> press ctrl+o
> cancel "Mount share" window
> press ctrl+q

This crash is still reproducible on Wayland with Oxygen app style.

Application: Smb4K (smb4k), signal: Segmentation fault
Content of s_kcrashErrorMessage: [Current thread is 1 (Thread 0x7f99c02a70c0 (LWP 4899))]
[KCrash Handler]
#6  0x00007f999e4300c4 in ?? () from /usr/lib/x86_64-linux-gnu/qt5/plugins/styles/oxygen.so
#7  0x00007f999e430479 in ?? () from /usr/lib/x86_64-linux-gnu/qt5/plugins/styles/oxygen.so
#8  0x00007f999e438141 in ?? () from /usr/lib/x86_64-linux-gnu/qt5/plugins/styles/oxygen.so
#9  0x00007f999e438179 in ?? () from /usr/lib/x86_64-linux-gnu/qt5/plugins/styles/oxygen.so
#10 0x00007f99bdb742f9 in QApplication::~QApplication (this=0x7fff54ad9070, __in_chrg=<optimized out>) at kernel/qapplication.cpp:812
#11 0x000055fb9b70bc75 in main (argc=<optimized out>, argv=<optimized out>) at ./smb4k/main.cpp:146
Comment 11 Patrick Silva 2020-07-23 13:09:21 UTC
Sorry, I forgot the softwares versions.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.73.0
Qt Version: 5.14.2
Comment 12 Patrick Silva 2020-07-23 13:17:44 UTC
in fact I can't reproduce with the steps quoted in comment 10.

exact steps:
open smb4k on Wayland
click on "File" menu, choose "Quit".
Comment 13 Vlad Zahorodnii 2020-07-30 07:54:41 UTC
@Patrick so should we close the bug report? or are you still able to reproduce the crash?
Comment 14 Patrick Silva 2020-07-30 11:29:49 UTC
The crash is still happening on both X11 and Wayland sessions.

1. set application style to Oxygen in system settings > application style
2. open smb4k
3. click on "File" menu, choose "Quit"
Comment 15 Nate Graham 2020-07-30 12:49:10 UTC
If it's crashing only when using Oxygen, should this be moved to Oxygen?
Comment 16 Wolfgang Bauer 2020-07-30 12:55:38 UTC
(In reply to Patrick Silva from comment #14)
> The crash is still happening on both X11 and Wayland sessions.
> 
> 1. set application style to Oxygen in system settings > application style
> 2. open smb4k
> 3. click on "File" menu, choose "Quit"
Hm, that doesn't crash here anymore. (with Plasma 5.19.4)

AFAICS, the fix (https://invent.kde.org/plasma/oxygen/-/merge_requests/1) has only been merged into the 5.19 branch though, not into master (that explains why it still crashes for you).
Comment 17 Wolfgang Bauer 2020-07-30 12:57:03 UTC
(In reply to Nate Graham from comment #15)
> If it's crashing only when using Oxygen, should this be moved to Oxygen?

This bug was originally reported for Breeze though.
So it's probably better to open a new one for Oxygen.

But see my previous comment, the only problem seems to be that the fix is missing in the master branch, i.e. 5.19 needs to be merged to master.
Comment 18 Nate Graham 2020-07-30 12:57:45 UTC
Good catch. Fixing that now.
Comment 19 Nate Graham 2020-07-30 13:03:14 UTC
Merged.
Comment 20 Vlad Zahorodnii 2020-07-30 14:18:07 UTC
(In reply to Nate Graham from comment #19)
> Merged.
Oops, looks like I forgot to merge Plasma 5.19 into master. Anyway, thank you for fixing that!
Comment 21 Nate Graham 2020-07-30 15:13:05 UTC
No worries, it happens to us all. :)