Created attachment 128401 [details]
I searched for mamojave laf global theme, installed it, closed GHNS window, reopened it, selected another option from the second dropdpwn on bottom,
then the GHNS window shown "Network error 5: operation canceled" error message twice. See the attached screenshot please.
error messages should never appear twice
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Well spotted, that's me forgetting to disconnect things that should be disconnected, thanks :)
Right, first merge request on invent, and it's this one ;) https://invent.kde.org/frameworks/knewstuff/-/merge_requests/1 is awaiting some reviewification
Git commit f02dfeecfc4f8f838a8fae0a270ed199ace7c05a by Dan Leinir Turthra Jensen.
Committed on 21/05/2020 at 12:44.
Pushed by ngraham into branch 'master'.
Don't duplicate error messages in a passive notification
We already show error messages properly in a non-passive popup,
and so it is just a little silly to also show them in a passive
M +0 -1 src/qtquick/qml/DialogContent.qml