Bug 421425 - GHNS window shows "Network error 5: operation canceled" error message twice
Summary: GHNS window shows "Network error 5: operation canceled" error message twice
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-12 17:43 UTC by Patrick Silva
Modified: 2020-05-22 19:47 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/knewstuff/commit/f02dfeecfc4f8f838a8fae0a270ed199ace7c05a
Version Fixed In: 5.71

Attachments
screenshot (150.68 KB, image/png)
2020-05-12 17:43 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-12 17:43:33 UTC 
Created attachment 128401 [details]
screenshot

SUMMARY
I searched for mamojave laf global theme, installed it, closed GHNS window, reopened it, selected another option from the second dropdpwn on bottom,
then the GHNS window shown "Network error 5: operation canceled" error message twice. See the attached screenshot please.

EXPECTED RESULT
error messages should never appear twice

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Comment 1 Dan Leinir Turthra Jensen 2020-05-13 08:09:54 UTC 
Well spotted, that's me forgetting to disconnect things that should be disconnected, thanks :)
Comment 2 Dan Leinir Turthra Jensen 2020-05-21 12:55:06 UTC 
Right, first merge request on invent, and it's this one ;) https://invent.kde.org/frameworks/knewstuff/-/merge_requests/1 is awaiting some reviewification
Comment 3 Dan Leinir Turthra Jensen 2020-05-22 19:47:00 UTC 
Git commit f02dfeecfc4f8f838a8fae0a270ed199ace7c05a by Dan Leinir Turthra Jensen.
Committed on 21/05/2020 at 12:44.
Pushed by ngraham into branch 'master'.

Don't duplicate error messages in a passive notification

We already show error messages properly in a non-passive popup,
and so it is just a little silly to also show them in a passive
notification.

M  +0    -1    src/qtquick/qml/DialogContent.qml

https://invent.kde.org/frameworks/knewstuff/commit/f02dfeecfc4f8f838a8fae0a270ed199ace7c05a