Bug 421382 - Add more kmymoney icons
Summary: Add more kmymoney icons
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-12 01:04 UTC by Dawid Wróbel
Modified: 2021-06-08 13:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Current Windows build icons situation (244.92 KB, image/png)
2020-05-12 01:04 UTC, Dawid Wróbel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Wróbel 2020-05-12 01:04:03 UTC
Created attachment 128379 [details]
Current Windows build icons situation

SUMMARY
Breeze theme misses kmymoney-specific icons. At this point, craft-generated Windows and macOS packages deliver an icontheme.rcc with embedded default Breeze theme.  KMyMoney *does* package and handle its own, context-specific icons, but only for oxygen, hi-color and Tango themes: https://cgit.kde.org/kmymoney.git/tree/kmymoney/icons

Some third party themes like Papirus also provide their own kmymoney icons (https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/bbf78721433f7b902f3d40fc13ba733e84136bd0, https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/68c73c9c6815c9aba3d75cb42230980641cde890)

It would be great if Breeze added missing icons upstream, so that kmymoney could default to using Breeze icon-set across all of the builds and simplify the codebase.
Comment 1 Dawid Wróbel 2020-05-12 01:59:22 UTC
Note that there is a project dedicated to cataloging/managing KDE finance icons, and this effort could also serve Skrooge:

https://techbase.kde.org/Projects/KdeFinanceCommonIcons
Comment 2 Dawid Wróbel 2020-05-12 02:12:41 UTC
It also looks like Skrooge has already had its Breeze icons moved upstream:

https://forum.kde.org/viewtopic.php?f=210&t=126929
https://cgit.kde.org/skrooge.git/commit/?id=161912ca12001a540a4248c96bb2fdd7c82add6b
Comment 3 Dawid Wróbel 2020-05-12 02:29:49 UTC
Here's a list of theme mappings kmymoney currently uses for its icons:
https://cgit.kde.org/kmymoney.git/tree/kmymoney/icons/icons.cpp

The mapping is created using the following logic:
1) load all the common icons, as defined by getCommonNames()
2) load all KDE icons, as defined by getKDENames(). If any were defined already, replace them.
3) load selected theme icons, as defined by getBreezeNames(), getTangoNames(), getOxygenNames(). If any were defined already, replace them.
Comment 4 Dawid Wróbel 2020-05-12 03:54:50 UTC
Digging deeper into the current state of things I can see that some icons are already available in Breeze.

Let me change the status of this report to NEEDSINFO and report back once I have a better idea of which particular icons are missing.
Comment 5 Dawid Wróbel 2020-05-17 22:58:34 UTC
These are the unique icons KMyMoney uses for its own purposes:

actions-account
actions-account-add
actions-account-close
actions-account-delete
actions-account-edit
actions-account-open
actions-account-reopen
actions-account-types-asset
actions-account-types-cash
actions-account-types-checking
actions-account-types-closed
actions-account-types-credit-card
actions-account-types-expense
actions-account-types-income
actions-account-types-investments
actions-account-types-liability
actions-account-types-loan
actions-account-types-reconciled
actions-account-types-savings
actions-account-update-online
actions-account-update-online-all
actions-accounts
actions-attention
actions-backup
actions-bank
actions-budget
actions-budget-add
actions-budget-delete
actions-budget-edit
actions-categories
actions-category-delete
actions-category-edit
actions-cleared
actions-close-window
actions-delete
actions-forecast
actions-hide-categories
actions-hide-reconciled
actions-home
actions-institution
actions-institution-add
actions-institution-delete
actions-institution-edit
actions-institutions
actions-investment
actions-investment-add
actions-investment-delete
actions-investment-edit
actions-investment-update-online
actions-investment-update-online-all
actions-investments
actions-ledger
actions-office-chart-tall-pie
actions-online-banking
actions-onlinebanking
actions-pay-edit
actions-payee
actions-payee-rename
actions-personal-data
actions-reconcile
actions-reconcile-finish
actions-report
actions-report-bar
actions-report-line
actions-report-pie
actions-report-solid
actions-report-text
actions-schedule
actions-set-as
actions-transaction
actions-transaction-add
actions-transaction-delete
actions-transaction-edit
actions-transaction-export
actions-transaction-find
actions-transaction-import
actions-transaction-report
actions-transaction-split
actions-unreconciled
actions-update-prices
actions-view-info

Additionally, a refreshed KMyMoney icon would be great. 

Some effort was already made in the past:
https://forum.kde.org/viewtopic.php?f=285&t=119635
Comment 6 Dawid Wróbel 2020-05-17 23:24:45 UTC
A -copy action for each of the below would also be nice, e.g. actions-account-copy, actions-transaction-copy, etc.
Comment 7 Dawid Wróbel 2020-05-18 00:53:34 UTC
Lastly, the following icons are missing the color option and would be otherwise perfect candidates for sidebar actions:

go-home-large 
view-statistics
tag
system-users/user-others
Comment 8 Dawid Wróbel 2020-05-27 23:11:02 UTC
I created a spreadsheet with all these icons, together with breeze counterparts, status and additional notes, as well as reference icons for comparison:

https://docs.google.com/spreadsheets/d/16BO7PqdC-mDcSAfHOSC7nROjNQY6msuRel9jSdH0XIs/edit#gid=0
Comment 9 Dawid Wróbel 2020-06-07 20:59:21 UTC
Some additional effort made in 2016:

https://forum.kde.org/viewtopic.php?f=69&t=133554
Comment 10 Dawid Wróbel 2021-06-08 05:40:04 UTC
This has been resolved and all the requested icons have been added to Breeze icon set.
Comment 11 Nate Graham 2021-06-08 13:33:47 UTC
Woohoo!