Bug 421374 - Service file specifiying 'Run in terminal' gives "Error code 100, Could not find the program ‘konsole’" after Plasma 5.18.5 update.
Summary: Service file specifiying 'Run in terminal' gives "Error code 100, Could not f...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: git master
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Jonathan Marten
URL:
Keywords: regression
: 421378 421454 421479 421587 421991 422270 422821 423207 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-11 21:13 UTC by lnxusr
Modified: 2020-06-19 23:05 UTC (History)
20 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.71


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lnxusr 2020-05-11 21:13:56 UTC
SUMMARY
After the 5.18.5 update, I get a "Could not find the program ‘konsole’ error" when trying to launch executable scripts directly with 'Run in terminal' checked in Advanced tab in the Menu Editor.


STEPS TO REPRODUCE
1. Have executable script (python, bash, etc) in Application Menu set to run in terminal with command "[path to script]/hello.sh"
2. Open Application Menu and select script to run.


OBSERVED RESULT
Error dialog stating "Could not find the program ‘konsole’" is displayed.

EXPECTED RESULT
Konsole opens with running script.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.18
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
Konsole itself runs fine from the Application Menu and a terminal window.  This appears to only affect applications set to run in a terminal from within the Application Menu.

This is also reported on the Manjaro forums:
https://forum.manjaro.org/t/could-not-find-the-program-konsole-error-after-manjaro-update/140484

I realise this is probably not a kmenuedit bug, but there is no Application Menu section and I have no idea where this should go.
Comment 1 Matty R 2020-05-11 23:38:43 UTC
*** Bug 421378 has been marked as a duplicate of this bug. ***
Comment 2 Kai Uwe Broulik 2020-05-12 07:53:31 UTC
I'm getting this on master with CommandLauncherJob, too.
@dfaure: Could this be a regression in KRun/KProcessRuner?
Comment 3 Kai Uwe Broulik 2020-05-12 07:55:00 UTC
(with ApplicationLauncherJob, obviously)
Comment 4 ryantg 2020-05-12 16:05:04 UTC
I'm experiencing this, too. My use case is that I have a .desktop launcher that contains

Terminal=true

And I receive that same error.
Comment 5 Patrick Silva 2020-05-13 00:19:11 UTC
I can confirm this bug on Arch Linux when I try to launch htop via kickoff.
Comment 6 tagwerk19 2020-05-13 06:54:49 UTC
Possibly related to Bug 421364
Comment 7 Duns 2020-05-13 09:15:24 UTC
same problem here, in KDE Neon after upgrade 5.18.5
Comment 8 Jonathan Marten 2020-05-13 10:38:07 UTC
(Copied from duplicate bug 421454)

SUMMARY

The desktop file:

[Desktop Entry]
Exec=ls 
Name=Terminal test
Terminal=true
TerminalOptions=--hold
Type=Application

should launch the default terminal application and execute the command.  However, as reported on bug #421364, if the desktop file is launched with 'kioclient5 exec test.desktop' or by any other means an error box is shown:

  Unknown error code 100
  Could not find the program 'konsole'
  Please send a full bug report at https://bugs.kde.org.

with the debug message:

  kioclient(1227906) findNonExecutableProgram: Internal program error.
  QStandardPaths::findExecutable couldn't find "konsole" but our own logic found it
  at "/usr/bin/konsole" . Please report a bug at https://bugs.kde.org

The problem seems to be in KIO::DesktopExecParser::resultingArguments() where, if service.terminal() is true, the user's configured terminal application or konsole as a default is prepended to the command line (with appropriate options).  However, this is most likely to be a relative path.  This then triggers the "nonExecutable" check in KProcessRunner::KProcessRunner().

STEPS TO REPRODUCE
1.  Execute the desktop file as above using kioclient5.

OBSERVED RESULT

Error and debug messages as above are shown, and no terminal is launched

EXPECTED RESULT

A terminal is launched and the current directory is listed

SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Comment 9 Jonathan Marten 2020-05-13 10:38:41 UTC
*** Bug 421454 has been marked as a duplicate of this bug. ***
Comment 10 Christoph Feck 2020-05-13 23:41:56 UTC
*** Bug 421479 has been marked as a duplicate of this bug. ***
Comment 11 Jonathan Marten 2020-05-14 09:42:45 UTC
https://phabricator.kde.org/D29738
Comment 12 Nate Graham 2020-05-14 15:12:07 UTC
Thanks for submitting a patch!
Comment 13 Duns 2020-05-14 15:55:42 UTC
So, we have to make some changes or to wait for KDE update?
Comment 14 Jonathan Marten 2020-05-14 18:26:17 UTC
Git commit 6452a34cf01d03d3167b38bc28a2fe8e13569021 by Jonathan Marten.
Committed on 14/05/2020 at 18:17.
Pushed by marten into branch 'master'.

Fix service file specifying 'Run in terminal' giving an error code 100

Happens because KIO::DesktopExecParser::resultingArguments() prepends
the terminal application to the command line.  If this is a relative path,
as it is most likely to be (and will be in the default 'konsole' case),
the "realExecutable" check in KProcessRunner::KProcessRunner() is triggered
and the job aborts with an error.

Expand the specified terminal executable into a full path in resultingArguments(),
and return an error immediately if it cannot be found.  This full terminal path
is not relative for the KProcessRunner::KProcessRunner() check and does not fail.

Check that resultingArguments() is not empty (an error return) before accessing
the first word of the command, so that it does not assert if the list is empty.
Also only call resultingArguments() once.
FIXED-IN: 5.71

Differential Revision: https://phabricator.kde.org/D29738

M  +9    -1    src/core/desktopexecparser.cpp
M  +9    -8    src/gui/kprocessrunner.cpp

https://commits.kde.org/kio/6452a34cf01d03d3167b38bc28a2fe8e13569021
Comment 15 Duns 2020-05-14 19:58:15 UTC
Thank you, but I don't understand yet what I should do (if I should do anything).
Comment 16 Nate Graham 2020-05-14 20:12:45 UTC
Wait for KDE Frameworks 5.71 to be released and then upgrade to it.
Comment 17 Patrick Silva 2020-05-14 20:43:30 UTC
Can this fix be applied to kio 5.70?
Comment 18 Nate Graham 2020-05-14 20:52:18 UTC
5.70 was already released and Frameworks do not have bugfix releases. It's up to distro packagers to backport the fix at this point, if they don't want their users to have to wait a month.
Comment 19 ryantg 2020-05-14 20:56:43 UTC
In case this is helpful (and not inappropriate to share here)...

Temporary workaround that works for my situation (.desktop file): 

Exec=/usr/bin/konsole -e "[path to script]/hello.sh"
Comment 20 sahsanu 2020-05-14 22:32:11 UTC
(In reply to ryantg from comment #19)
> In case this is helpful (and not inappropriate to share here)...
> 
> Temporary workaround that works for my situation (.desktop file): 
> 
> Exec=/usr/bin/konsole -e "[path to script]/hello.sh"

Besides to apply the proposed Exec change, if your desktop file contains Terminal=true remember to change it to false Terminal=false
Comment 21 Patrick Silva 2020-05-16 01:14:37 UTC
*** Bug 421587 has been marked as a duplicate of this bug. ***
Comment 22 Patrick Silva 2020-05-23 19:14:48 UTC
*** Bug 421991 has been marked as a duplicate of this bug. ***
Comment 23 Ahmad Samir 2020-05-31 06:52:16 UTC
*** Bug 422270 has been marked as a duplicate of this bug. ***
Comment 24 robyfary 2020-06-06 14:42:49 UTC
(In reply to sahsanu from comment #20)
> (In reply to ryantg from comment #19)
> > In case this is helpful (and not inappropriate to share here)...
> > 
> > Temporary workaround that works for my situation (.desktop file): 
> > 
> > Exec=/usr/bin/konsole -e "[path to script]/hello.sh"
> 
> Besides to apply the proposed Exec change, if your desktop file contains
> Terminal=true remember to change it to false Terminal=false

I need to keep "on hold" the konsole, otherwise it closes too fast.
I use : Exec=/usr/bin/konsole --hold -e "[path to script]/hello.sh"
Comment 25 Alex Fliker 2020-06-10 20:56:42 UTC
Just upgraded to the latest 5.19 and the bug is still there :-| When is it going to get pushed to the users?
Comment 26 Patrick Silva 2020-06-10 21:00:06 UTC
on next Saturday

https://community.kde.org/Schedules/Frameworks
Comment 27 Patrick Silva 2020-06-11 20:39:53 UTC
*** Bug 422821 has been marked as a duplicate of this bug. ***
Comment 28 Wolfgang Bauer 2020-06-19 23:05:07 UTC
*** Bug 423207 has been marked as a duplicate of this bug. ***