Bug 421335 - New Global Shortcuts KCM: some system services have a generic icon
Summary: New Global Shortcuts KCM: some system services have a generic icon
Status: RESOLVED NOT A BUG
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keys (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Jansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-11 12:49 UTC by Patrick Silva
Modified: 2020-07-14 17:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot (113.86 KB, image/png)
2020-05-11 12:49 UTC, Patrick Silva
Details
screenshot of old kcm (98.07 KB, image/png)
2020-05-11 16:50 UTC, Patrick Silva
Details
Clementine is installed - with icon under "Applications" (31.45 KB, image/png)
2020-05-18 21:59 UTC, Patrick Silva
Details
Clementine was uninstalled - without icon under "System Services" (41.54 KB, image/png)
2020-05-18 22:00 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-11 12:49:22 UTC
Created attachment 128359 [details]
screenshot

SUMMARY
See the attached screenshot please.
The following system services have a generic icon:
activity manager
clementine
keyboard layout switcher
krunner
power management

STEPS TO REPRODUCE
1. open system settings > shortcuts
2. 
3. 

EXPECTED RESULT
system services should have their own icons

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Comment 1 David Redondo 2020-05-11 16:34:18 UTC
Is that a regression compared to the old one? If not, I think this needs to be fixed in the components themselves.
Comment 2 Patrick Silva 2020-05-11 16:41:46 UTC
I noticed this issue immediately when the new kcm landed on neon unstable.
Comment 3 David Redondo 2020-05-11 16:43:29 UTC
The old also had components without an icon and displayed a generic one instead.
Comment 4 Patrick Silva 2020-05-11 16:50:42 UTC
Created attachment 128367 [details]
screenshot of old kcm

At least on Arch Linux the old kcm displays no generic icon.
Comment 5 Patrick Silva 2020-05-11 16:52:10 UTC
nevermind, they are different icons but they are also generic.
Comment 6 Nate Graham 2020-05-12 16:06:00 UTC
In fact you can see the same generic icons in the old KCM. The generic icon itself changed though.

David is right; this needs to be fixed in the services themselves. Please file one bug per item that should have a better icon. Thanks!
Comment 7 David Redondo 2020-05-17 11:38:03 UTC
I looked into Clementine and it has an icon on my system. Maybe because its desktop file is not in a correct location on your system?
Comment 8 Patrick Silva 2020-05-18 21:59:05 UTC
Created attachment 128587 [details]
Clementine is installed - with icon under "Applications"

Clementine was not installed on my neon unstable.
I downloaded and installed the latest build from the following link
https://github.com/clementine-player/Clementine/releases

When installed, Clementine is listed under "Applications" with icon.
Then I uninstalled Clementine again and now it is listed under "System Services"
without icon again. I'm attaching screenshots.
Comment 9 Patrick Silva 2020-05-18 22:00:57 UTC
Created attachment 128588 [details]
Clementine was uninstalled - without icon under "System Services"
Comment 10 David Redondo 2020-05-19 07:35:11 UTC
Yes that's how it works. The kcm tries to find ot if something is an application or not. If it can't determine or doesn't find information (because no desktop file is around because the app is uninstalled) than the default is System Services. Notifications kcm has the same logic afaik
Comment 11 Patrick Silva 2020-05-19 11:23:42 UTC
Why does the entry of an already uninstalled app remain in Global Shortcuts kcm?
This behavior occurs even with KDE software (tested with yakuake on neon unstable).
If a user installs and uninstalls several apps for test purposes for example the result could be a Global Shortcuts kcm with several completely useless entries
under "System Services".
Talking about Notifications kcm, yakuake is only present there if installed.
Comment 12 David Redondo 2020-05-19 15:43:55 UTC
The notifications kcm uses notifyrc files to list kde stuff that sends notifications (other story for 3rd party). So if you uninstall yakuake it also removes the notifyrc file and will not appear. If you remove an application its shortcuts stays registered with kglobalaccel because well nothing unregistered them. I don't know of a straightforward way to determine if the thing that registered a shortcut is uninstalled or not because component names are abitrary and not bound to some file like in the notifications case. 
The notifications kcm example was just to point out that it uses the same default of system service if it can't determine if something is an application or not.
Comment 13 Patrick Silva 2020-05-19 16:09:12 UTC
Thanks for clarifying David.

I have just noticed that we can manually remove the entries of already uninstalled apps by clicking on their trash icon.
Comment 14 Patrick Silva 2020-07-14 13:43:08 UTC
(In reply to Nate Graham from comment #6)
> David is right; this needs to be fixed in the services themselves. Please
> file one bug per item that should have a better icon. Thanks!

done
https://bugs.kde.org/show_bug.cgi?id=424197
https://bugs.kde.org/show_bug.cgi?id=424198
https://bugs.kde.org/show_bug.cgi?id=424194
https://bugs.kde.org/show_bug.cgi?id=424195
Comment 15 Nate Graham 2020-07-14 17:03:53 UTC
Thanks!