Bug 421332 - Overwriting an existing save game doesn't work
Summary: Overwriting an existing save game doesn't work
Status: RESOLVED FIXED
Alias: None
Product: ksudoku
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ian Wadham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-11 11:46 UTC by julius@albonham.demon.nl
Modified: 2020-05-30 08:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description julius@albonham.demon.nl 2020-05-11 11:46:40 UTC
SUMMARY


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Have used KSudoku a long time. Now, after updating SolydX, KSudoku will not store the game.
Comment 1 Albert Astals Cid 2020-05-11 21:08:37 UTC
Maybe you can tell us the version you are using now? (and ideally the one you were using before).
Comment 2 julius@albonham.demon.nl 2020-05-12 09:34:11 UTC
Thanks for your swift response.

My KSudoku version is 1.4, not the latest version. Before the 
SolydX-update I've also used this version. It is part of the repository.

Thanks, Julius



Op 11-05-2020 om 23:08 schreef Albert Astals Cid:
> https://bugs.kde.org/show_bug.cgi?id=421332
>
> Albert Astals Cid <aacid@kde.org> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>           Resolution|---                         |WAITINGFORINFO
>               Status|REPORTED                    |NEEDSINFO
>                   CC|                            |aacid@kde.org
>
> --- Comment #1 from Albert Astals Cid <aacid@kde.org> ---
> Maybe you can tell us the version you are using now? (and ideally the one you
> were using before).
>
Comment 3 Albert Astals Cid 2020-05-12 17:56:56 UTC
Can you please clarify what "KSudoku will not store the game" exactly means?
Comment 4 julius@albonham.demon.nl 2020-05-13 08:30:43 UTC
Soring the game = saving the running game.

bye, Julius

Op 12-05-2020 om 19:56 schreef Albert Astals Cid:
> https://bugs.kde.org/show_bug.cgi?id=421332
>
> --- Comment #3 from Albert Astals Cid <aacid@kde.org> ---
> Can you please clarify what "KSudoku will not store the game" exactly means?
>
Comment 5 julius@albonham.demon.nl 2020-05-13 09:48:30 UTC
Possibly this will help: Solydx also uses the Debian Buster strain! I 
saw on your site that Ksudoku is set up for squeeze!

Bye, Julius

Op 12-05-2020 om 19:56 schreef Albert Astals Cid:
> https://bugs.kde.org/show_bug.cgi?id=421332
>
> --- Comment #3 from Albert Astals Cid <aacid@kde.org> ---
> Can you please clarify what "KSudoku will not store the game" exactly means?
>
Comment 6 Albert Astals Cid 2020-05-13 21:09:04 UTC
saving the running game.

By using File -> Save?
Comment 7 julius@albonham.demon.nl 2020-05-14 08:53:05 UTC
Yes of course.


I've tried to save the file to my desktop, that works fine. I the past I 
saveed the file to a folder and that doesnot work. Then an idea struck 
me: In the past I saved the file to an existing file so that file would 
be over written. This doesnot work. If I give the file a new name it is 
no problem.

So in  short: saving the game to an existing file(name) doesnot work. 
When you give that game a new name there is no problem.

Bye, Julius

Op 13-05-2020 om 23:09 schreef Albert Astals Cid:
> https://bugs.kde.org/show_bug.cgi?id=421332
>
> --- Comment #6 from Albert Astals Cid <aacid@kde.org> ---
> saving the running game.
>
> By using File -> Save?
>
Comment 8 Albert Astals Cid 2020-05-16 16:05:21 UTC
Ok, now that you made the effort to actually write more than 1 word, we know what's wrong, cool. 

Now maybe we can fix it :)
Comment 9 julius@albonham.demon.nl 2020-05-16 16:14:38 UTC
I notice from your remarks that not everything I’ve typed has reached you. Sorry about that but that is not my doing. What I’ve done is research the problem from my end and informed you accordingly.
Good luck and happy hunting.
Bye Julius

> Op 16 mei 2020 om 18:05 heeft Albert Astals Cid <bugzilla_noreply@kde.org> het volgende geschreven:
> 
> https://bugs.kde.org/show_bug.cgi?id=421332
> 
> Albert Astals Cid <aacid@kde.org> changed:
> 
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>     Ever confirmed|0                           |1
>             Status|NEEDSINFO                   |CONFIRMED
>         Resolution|WAITINGFORINFO              |---
> 
> --- Comment #8 from Albert Astals Cid <aacid@kde.org> ---
> Ok, now that you made the effort to actually write more than 1 word, we know
> what's wrong, cool. 
> 
> Now maybe we can fix it :)
> 
> -- 
> You are receiving this mail because:
> You reported the bug.
Comment 10 Albert Astals Cid 2020-05-26 22:34:11 UTC
Git commit 5a4871302cb64afc2475083e97e4ac5bf3a3e400 by Albert Astals Cid.
Committed on 26/05/2020 at 22:32.
Pushed by aacid into branch 'release/20.04'.

Fix saving over an existing save file

We can just overwrite all the paths that lead to here have already asked
if we want to overwrite (from the dialog) or we're just saving the same
file and thus overwriting makes sense

M  +1    -1    src/gui/serializer.cpp

https://invent.kde.org/games/ksudoku/commit/5a4871302cb64afc2475083e97e4ac5bf3a3e400
Comment 11 julius@albonham.demon.nl 2020-05-30 08:05:03 UTC
Well done!

Thanks, Julius

Op 27-05-2020 om 00:34 schreef Albert Astals Cid:
> https://bugs.kde.org/show_bug.cgi?id=421332
>
> Albert Astals Cid <aacid@kde.org> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>           Resolution|---                         |FIXED
>        Latest Commit|                            |https://invent.kde.org/game
>                     |                            |s/ksudoku/commit/5a4871302c
>                     |                            |b64afc2475083e97e4ac5bf3a3e
>                     |                            |400
>               Status|CONFIRMED                   |RESOLVED
>
> --- Comment #10 from Albert Astals Cid <aacid@kde.org> ---
> Git commit 5a4871302cb64afc2475083e97e4ac5bf3a3e400 by Albert Astals Cid.
> Committed on 26/05/2020 at 22:32.
> Pushed by aacid into branch 'release/20.04'.
>
> Fix saving over an existing save file
>
> We can just overwrite all the paths that lead to here have already asked
> if we want to overwrite (from the dialog) or we're just saving the same
> file and thus overwriting makes sense
>
> M  +1    -1    src/gui/serializer.cpp
>
> https://invent.kde.org/games/ksudoku/commit/5a4871302cb64afc2475083e97e4ac5bf3a3e400
>