Bug 421270 - GHNS windows show unreadable error messages with Breeze Dark global theme
Summary: GHNS windows show unreadable error messages with Breeze Dark global theme
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
: 424407 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-10 10:22 UTC by Patrick Silva
Modified: 2020-07-19 15:44 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.71


Attachments
error message 1 (146.24 KB, image/png)
2020-05-10 10:22 UTC, Patrick Silva
Details
error message 2 (113.68 KB, image/png)
2020-05-10 10:22 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-10 10:22:30 UTC
Created attachment 128328 [details]
error message 1

SUMMARY
This issue affects Arch (frameworks 5.70) and Neon unstable edition.
If used global theme is Breeze Dark, GHNS windows show unredable error messages
when addon installation/update fails. See the attached screenshots please.


EXPECTED RESULT
error messages should always be readable.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Comment 1 Patrick Silva 2020-05-10 10:22:54 UTC
Created attachment 128329 [details]
error message 2
Comment 2 Dan Leinir Turthra Jensen 2020-05-12 13:46:47 UTC
Confirmed, and i've got a patch ready for you to test up here: https://phabricator.kde.org/D29678 - turns out that TextEdit isn't covered by the automagic theming in Kirigami, and this report is the result. Well spotted, thank you :)
Comment 3 Dan Leinir Turthra Jensen 2020-05-13 19:49:53 UTC
Git commit 5ce4d1a29b9696d59450a960da2d9df0136673a5 by Dan Leinir Turthra Jensen.
Committed on 13/05/2020 at 19:49.
Pushed by leinir into branch 'master'.

Fix incorrect colours in the KNS Quick messagebox

Summary:
Explicitly set the colours used in the messagebox' content item,
as the theme does not propagate to the simpler items, only to
those based on top of QtQuick Controls.

Test Plan: Ensure you are using a dark colour scheme. Provoke an error dialog in any KNewStuff Quick dialog, and see that this patch makes the error message colour turn from a near-invisible text on a dark background (as shown in https://bugs.kde.org/show_bug.cgi?id=421270) to a visible text on a dark background.

Reviewers: #frameworks, #knewstuff, #plasma, bugseforuns, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29678

M  +6    -0    src/qtquick/qml/private/MessageBoxSheet.qml

https://commits.kde.org/knewstuff/5ce4d1a29b9696d59450a960da2d9df0136673a5
Comment 4 Patrick Silva 2020-07-19 15:44:31 UTC
*** Bug 424407 has been marked as a duplicate of this bug. ***