SUMMARY kid3 flags ISRC tags with the new QM (USA) country code as invalid STEPS TO REPRODUCE 1. Enter a ISRC tag with a QM country code (example: QM2DP2000004) 2. 3. OBSERVED RESULT ISRC code field is highlighted in red. The tag appears to be correctly saved to the file. EXPECTED RESULT Should accept code. SOFTWARE/OS VERSIONS Windows: 7 Build 7601 macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION Thanks for a great tagger.
Thanks for the report. Are you sure that it is really "QM2DP2000004" which is not accepted as an ISRC? I cannot reproduce it. The code which checks ISRC code is simple (see below), it basically checks if - the length is 12, - the first five characters are letters or numbers, - the last seven characters are numbers. All this is true for "QM2DP2000004" and therefore I do not see any red highlight. ~~~ bool isIsrc(const QString& str) { if (str.length() != 12) return false; for (int i = 0; i < 5; ++i) { if (!str.at(i).isLetterOrNumber()) { return false; } } for (int i = 5; i < 12; ++i) { if (!str.at(i).isDigit()) { return false; } } return true; } ~~~
Please check again or attach a file to reproduce it.
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
Created attachment 128790 [details] attachment-10265-0.html This is weird. I cannot now reproduce the bug. I'm not sure why it acts differently now. But at least it works. Thanks. Philbo King On Sunday, May 24, 2020, 11:33:17 PM CDT, Bug Janitor Service <bugzilla_noreply@kde.org> wrote: https://bugs.kde.org/show_bug.cgi?id=421201 --- Comment #3 from Bug Janitor Service <bug-janitor@kde.org> --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!