Bug 421072 - Usage of strange `= +` operators in KoOdfNumberStyles.cpp
Summary: Usage of strange `= +` operators in KoOdfNumberStyles.cpp
Status: RESOLVED UNMAINTAINED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-05 19:36 UTC by Rafał Mikrut
Modified: 2020-08-20 21:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mikrut 2020-05-05 19:36:00 UTC 
```
format = + ',' ;
```

https://invent.kde.org/kde/krita/-/blob/master/libs/odf/KoOdfNumberStyles.cpp#L456
Comment 1 Tiar 2020-05-05 19:56:57 UTC 
That looks like a bug long time ago, someone wrote =+ instead of +=, then someone "fixed the coding style" by adding a space between them, then it was commented out because of a warning that suggested that this code won;t be executed, then someone uncommented it... Quite a weird situation.

@Rafał, how did you find this bug? Also would you want to contribute a patch? That would be quite easy, I believe.
Comment 2 Dmitry Kazakov 2020-08-20 21:48:22 UTC 
Okay, entire ODF code has been removed in master. I guess we should just close the report.

Though I would really love to know how Rafał managed to find this bug :)