Bug 420996 - tiff import filter does not support pre-multiplied alpha
Summary: tiff import filter does not support pre-multiplied alpha
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on: 438655
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-04 12:06 UTC by Aaron Boxer
Modified: 2021-06-25 18:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Boxer 2020-05-04 12:06:48 UTC
Please see this github issue and attached files:

https://github.com/libvips/libvips/issues/1634#issuecomment-623309992


1) 16 bit is not handled correctly
2) 2nd alpha channel is missing for 16 bit image
3) "spot" colour is missing
Comment 1 Halla Rempt 2020-05-04 12:09:14 UTC
Please, this doesn't work. If we need to test with a certain file, attach the file to the bug report. And some things just aren't supported in Krita, like second alpha channels or spot colors. We might want to implement that at one point, but not now.
Comment 2 Aaron Boxer 2020-05-04 12:24:16 UTC
Thanks, and my apologies for the link - those files are too large to add as attachments. 
I wasn't aware that spot is not supported. So, forget about the spot issue :)

So, left with:

16 bit colour is not displayed correctly.
Comment 3 Bug Janitor Service 2020-05-05 04:33:16 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Halla Rempt 2020-05-06 13:49:02 UTC
Running from the terminal gives:

Extra sample type not defined for this file, assuming unassociated alpha.
Extra sample type not defined for this file, assuming unassociated alpha.
Associated alpha in this file: krita does not handle plremultiplied alpha.
Extra sample type not defined for this file, assuming unassociated alpha.
Extra sample type not defined for this file, assuming unassociated alpha.
Associated alpha in this file: krita does not handle plremultiplied alpha.
Extra sample type not defined for this file, assuming unassociated alpha.
Extra sample type not defined for this file, assuming unassociated alpha.
Extra sample type not defined for this file, assuming unassociated alpha.
Extra sample type not defined for this file, assuming unassociated alpha.


So, basically this kind of transparency isn't supported yet.
Comment 5 Bug Janitor Service 2021-06-13 23:52:13 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/907
Comment 6 amyspark 2021-06-25 18:32:00 UTC
Git commit 398cfdb238631b6e3e1170baff809a7743a3a767 by L. E. Segovia.
Committed on 17/06/2021 at 23:36.
Pushed by lsegovia into branch 'master'.

TIFF: correctly process premultiplied alpha

M  +26   -14   plugins/impex/tiff/kis_tiff_converter.cc
M  +63   -2    plugins/impex/tiff/kis_tiff_reader.h
M  +52   -1    plugins/impex/tiff/kis_tiff_ycbcr_reader.h
A  +-    --    plugins/impex/tiff/tests/data/results/red.tif.png
A  +-    --    plugins/impex/tiff/tests/data/sources/red.tif

https://invent.kde.org/graphics/krita/commit/398cfdb238631b6e3e1170baff809a7743a3a767