Created attachment 128125 [details]
attachment-15924-0.html

I'd like to work on this later today.

On Mon, 4 May, 2020, 12:48 pm , <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=420984
>
>             Bug ID: 420984
>            Summary: Problem when compiling kio-extras in craft in Windows
>                     10 Home China
>            Product: Craft
>            Version: master
>           Platform: MS Windows
>                 OS: MS Windows
>             Status: REPORTED
>           Severity: normal
>           Priority: NOR
>          Component: Core
>           Assignee: vonreth@kde.org
>           Reporter: sdplus2019@163.com
>                 CC: kde-windows@kde.org
>   Target Milestone: ---
>
> SUMMARY
> When "Building CXX object sftp\CMakeFiles\kio_sftp.dir\kio_sftp.cpp.obj" it
> failed.
>
> STEPS TO REPRODUCE
> 1. Open Powershell (I use Windows Terminal Preview)
> 2. Start craft
> 3. run "craft dolphin"
>
> OBSERVED RESULT
> FAILED: sftp/CMakeFiles/kio_sftp.dir/kio_sftp.cpp.obj
>
> C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\bin\Hostx64\x64\cl.exe
>  /nologo /TP -DKCOREADDONS_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB
> -DQT_DBUS_LIB
> -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_URL_CAST_FROM_STRING
> -DQT_WIDGETS_LIB -DTRANSLATION_DOMAIN=\"kio5_sftp\" -DUNICODE
> -DWIN32_LEAN_AND_MEAN -DWINVER=0x0600 -D_CRT_NONSTDC_NO_DEPRECATE
> -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS
> -D_SCL_SECURE_NO_WARNINGS
> -D_UNICODE -D_USE_MATH_DEFINES -D_WIN32_IE=0x0600 -D_WIN32_WINNT=0x0600
> -Dkio_sftp_EXPORTS -Isftp
> -IC:\CraftRoot\build\_\9a54cb8a\kio-extras-20.04.0\sftp
> -Isftp\kio_sftp_autogen\include -I. -I\default -IC:\CraftRoot\include
> -IC:\CraftRoot\include\KF5\KIOCore -IC:\CraftRoot\include\KF5
> -IC:\CraftRoot\include\KF5\KCoreAddons -IC:\CraftRoot\include\qt5
> -IC:\CraftRoot\include\qt5\QtCore -IC:\CraftRoot\.\mkspecs\win32-msvc
> -IC:\CraftRoot\include\KF5\KService -IC:\CraftRoot\include\KF5\KConfigCore
> -IC:\CraftRoot\include\qt5\QtNetwork
> -IC:\CraftRoot\include\qt5\QtConcurrent
> -IC:\CraftRoot\include\qt5\QtDBus -IC:\CraftRoot\include\KF5\KWidgetsAddons
> -IC:\CraftRoot\include\qt5\QtWidgets -IC:\CraftRoot\include\qt5\QtGui
> -IC:\CraftRoot\include\qt5\QtANGLE -IC:\CraftRoot\include\KF5\KI18n /DWIN32
> /D_WINDOWS /W3 /GR /EHsc /wd4250 /wd4251 /wd4396 /wd4661 /MD /Zi /O2 /Ob1
> /DNDEBUG /showIncludes /Fosftp\CMakeFiles\kio_sftp.dir\kio_sftp.cpp.obj
> /Fdsftp\CMakeFiles\kio_sftp.dir\ /FS -c
> C:\CraftRoot\build\_\9a54cb8a\kio-extras-20.04.0\sftp\kio_sftp.cpp
> C:\Program Files (x86)\Microsoft Visual
>
> Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\experimental/filesystem(30):
> fatal error C1189: #error:  The <experimental/filesystem> header providing
> std::experimental::filesystem is deprecated by Microsoft and will be
> REMOVED.
> It is superseded by the C++17 <filesystem> header providing
> std::filesystem.
> You can define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING to
> acknowledge that you have received this warning.
>
> EXPECTED RESULT
>
>
> SOFTWARE/OS VERSIONS
> Windows: 10 19041.208 Home China
>
> ADDITIONAL INFORMATION
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Please see also https://binary-factory.kde.org/job/Dolphin_Release_win64/779/console

kio-extras is a frequent source of issues on Windows unfortunately.

Oh I forgot, I'm using windows-msvc2019_64-cl as the compiler...

> Please see also https://binary- 
> factory.kde.org/job/Dolphin_Release_win64/779/console

> kio-extras is a frequent source of issues on Windows unfortunately.


Ah yes, obviously, porting kio_sftp to windows is my doing. xD
I'll fix it.

The patch is in review: https://phabricator.kde.org/D29461

(In reply to brute4s99 from comment #5)
> The patch is in review: https://phabricator.kde.org/D29461

Oh, maybe there is a difference between vs2017 and vs2019, the error information said "The <experimental/filesystem> header providing std::experimental::filesystem is deprecated by Microsoft and will be REMOVED.". I tried to modify the file (deleted the two "experimental") and added /std:c++17 to the command. After that I got the output just like "Comment 2" mentioned. Maybe there should be different versions for vs2017 and vs2019 compiler.