Bug 420964 - Current Track applet layout a mess
Summary: Current Track applet layout a mess
Status: VERIFIED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View/Current Track (other bugs)
Version First Reported In: kf5
Platform: Other Linux
: NOR normal
Target Milestone: kf5
Assignee: Amarok Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-03 19:35 UTC by Cristian Tibirna
Modified: 2024-05-29 13:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Image of the messed Current Track applet (442.22 KB, image/png)
2020-05-03 19:35 UTC, Cristian Tibirna
Details
State of Current Track in 2.9.71+ when narrow (249.44 KB, image/png)
2024-03-24 14:47 UTC, Tuomas Nurmi
Details
Two-row mode, code in linked merge request (749.72 KB, image/png)
2024-03-25 13:58 UTC, Tuomas Nurmi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cristian Tibirna 2020-05-03 19:35:45 UTC
Created attachment 128115 [details]
Image of the messed Current Track applet

SUMMARY


STEPS TO REPRODUCE
1. Look at the attached screenshot
2. Open Amarok
3. Observe the same as in attached screenshot

OBSERVED RESULT
Layout of the Current Track applet is a mess.

EXPECTED RESULT
Layout of the Current Track applet to not be a mess.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: OpenSuSE Leap 15.1
(available in About System)
KDE Plasma Version: 5.12
KDE Frameworks Version: 5.55
Qt Version: 5.9.7

ADDITIONAL INFORMATION
Comment 1 Myriam Schweingruber 2020-05-04 09:42:04 UTC
are you sure this is Amarok 2.9.0? 

FWIW: this version relies on KDE4 and Qt4 libraries and is therefore now obsolete, Tumbleweed provides an alpha version of current master, and a first alpha release is in the make. Help greatly welcome :-)
Comment 2 Cristian Tibirna 2020-05-04 13:51:48 UTC
I have no means of checking the version of the component itself. It's whatever comes with Amarok 2.9.70 (hence my choice of version for the component from whatever is available in the popdown version list in the report form). The versions of other components are marked in the initial report.
Comment 3 Myriam Schweingruber 2020-05-05 07:59:33 UTC
I guessed as much, as my version of 2.9.0 shows correctly, 2.9.70 is an alpha build of the Qt5 port that doesn't have everything polished yet, especially the Context View
Comment 4 Pedro de Carvalho Gomes 2020-05-05 15:33:08 UTC
Right now the "Current track" applet at this point doesn't allow resizing. Also, it loads covers with large size. Thus, when the applet doesn't have all required size (for example, in low-resolution screens), the rest is simply hidden to the right

I might take a look at this applet soon. This size issue has been bothering me for a while as well.
Comment 5 Tuomas Nurmi 2024-03-24 14:47:32 UTC
Created attachment 167700 [details]
State of Current Track in 2.9.71+ when narrow

Better nowadays. Maybe not fully perfect when the width goes very small, but it remains quite ok, with font sizes scaling and longer texts getting ellipsed.
Comment 6 Cristian Tibirna 2024-03-25 11:18:11 UTC
(In reply to Tuomas Nurmi from comment #5)
> Created attachment 167700 [details]
> State of Current Track in 2.9.71+ when narrow
> 
> Better nowadays. Maybe not fully perfect when the width goes very small, but
> it remains quite ok, with font sizes scaling and longer texts getting
> ellipsed.

The ellipsing was one of the issues. As you can see, there would be enough space underneath the stars row to show the whole title. The real issue is that the stars widget appears to occupy the full height to the right, and doesn't size-scale.

So no, it's not solved.

I meant to take a look at this myself for some time now. I'll strive to it maybe over the summer.
Comment 7 Tuomas Nurmi 2024-03-25 13:58:30 UTC
Created attachment 167738 [details]
Two-row mode, code in linked merge request

Yeah, true, could be better.
I was just doing some fine-tuning on context applets so I added also some remedy for this, as shown in the attached screenshot. 

Code is at https://invent.kde.org/multimedia/amarok/-/merge_requests/65 , I think I'll still try to make the two-row mode scale down a bit nicer, though.
Comment 8 Cristian Tibirna 2024-03-26 01:22:53 UTC
(In reply to Tuomas Nurmi from comment #7)
> Created attachment 167738 [details]
> Two-row mode, code in linked merge request

Many thanks for this. Greatly appreciated!
Comment 9 Tuomas Nurmi 2024-03-26 07:53:18 UTC
(In reply to Cristian Tibirna from comment #8)
> (In reply to Tuomas Nurmi from comment #7)
> > Created attachment 167738 [details]
> > Two-row mode, code in linked merge request
> 
> Many thanks for this. Greatly appreciated!

You're welcome! Nice to hear.
I hope to finish polishing some of the context applets maybe this week and then merge to git master. (Aiming for a new alpha release in April.)
Comment 10 Tuomas Nurmi 2024-04-03 18:50:18 UTC
Git commit 79bccba33b909226c22c2fcdc0954c405a2abc88 by Tuomas Nurmi.
Committed on 03/04/2024 at 15:22.
Pushed by nurmi into branch 'master'.

Make current track applet behave better on narrow widths.

First some scaling of fonts and rating stars, then two row mode and then even
more scaling of fonts.

M  +4    -3    ChangeLog
M  +20   -9    src/context/applets/currenttrack/package/contents/ui/main.qml

https://invent.kde.org/multimedia/amarok/-/commit/79bccba33b909226c22c2fcdc0954c405a2abc88
Comment 11 Cristian Tibirna 2024-05-29 13:31:26 UTC
Thank you very much! The new layout is functional and looks nice!
Comment 12 Tuomas Nurmi 2024-05-29 13:51:59 UTC
Great to hear, thank you! Happy listening!