Bug 420934 - Tooltips of Touchpad applet in systray and some widgets added to plasma panel still have an icon on Neon unstable
Summary: Tooltips of Touchpad applet in systray and some widgets added to plasma panel...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-02 23:16 UTC by Patrick Silva
Modified: 2020-05-11 17:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.0


Attachments
screen recording (2.16 MB, video/webm)
2020-05-02 23:16 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-02 23:16:24 UTC
Created attachment 128106 [details]
screen recording

SUMMARY
On master branch the icons of tooltips shown by systray icons and widgets placed on plasma panel were removed.
However, the Touchpad applet in systray and the following widgets added to plasma panel are still showing an icon in their tooltips:
show desktop
minimize all windows
trash
touchpad
quicklaunch
quick share
lock/logout
activities

STEPS TO REPRODUCE
1. enable the Touchpad applet in systray settings
2. add any of the widgets mentioned above to plasma panel
3. hover over the Touchpad applet in systray and the just added widget

OBSERVED RESULT
tooltip with an icon. Watch the attached screen recording please.


EXPECTED RESULT
tooltip without icon

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-05-07 18:43:49 UTC
These were supposed to go away automatically. :/ I hope they're not all using custom tooltips...
Comment 2 Nate Graham 2020-05-07 18:51:43 UTC
Oh boy, they are. Why can't anything ever be easy...
Comment 4 Nate Graham 2020-05-08 20:33:04 UTC
Git commit fe20601bddd59ff2bc09c42cb735c576ee8489d5 by Nate Graham.
Committed on 08/05/2020 at 20:32.
Pushed by ngraham into branch 'master'.

Remove remaining icon from applet with custom tooltip

Summary:
Last bits needed for T12778.

Test Plan: {F8295118}

Reviewers: bugseforuns, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T12778

Differential Revision: https://phabricator.kde.org/D29516

M  +0    -1    applets/lock_logout/contents/ui/lockout.qml

https://commits.kde.org/plasma-workspace/fe20601bddd59ff2bc09c42cb735c576ee8489d5
Comment 5 Nate Graham 2020-05-08 20:34:06 UTC
Git commit 1d64bd11923569258a2633a55c9a9eaea67cefaa by Nate Graham.
Committed on 08/05/2020 at 20:33.
Pushed by ngraham into branch 'master'.

Remove remaining icons from applets with custom tooltips

Summary:
Last bits needed for T12778.

Test Plan: {F8295118}

Reviewers: bugseforuns, #plasma, #vdg, kmaterka

Reviewed By: kmaterka

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T12778

Differential Revision: https://phabricator.kde.org/D29517

M  +0    -1    applets/quicklaunch/package/contents/ui/main.qml
M  +0    -5    applets/quickshare/plasmoid/contents/ui/main.qml

https://commits.kde.org/kdeplasma-addons/1d64bd11923569258a2633a55c9a9eaea67cefaa
Comment 6 Nate Graham 2020-05-08 20:35:13 UTC
Git commit eeab79954d7dc5c093d7ed248f255c7232641d15 by Nate Graham.
Committed on 08/05/2020 at 20:35.
Pushed by ngraham into branch 'master'.

Remove remaining icons from applets with custom tooltips

Summary:
Last bits needed for T12778.

Test Plan: {F8295118}

Reviewers: bugseforuns, #plasma, #vdg, kmaterka, ndavis

Reviewed By: #vdg, kmaterka, ndavis

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T12778

Differential Revision: https://phabricator.kde.org/D29518

M  +0    -1    applets/minimizeall/package/contents/ui/main.qml
M  +0    -1    applets/showActivityManager/package/contents/ui/main.qml
M  +0    -1    applets/showdesktop/package/contents/ui/main.qml
M  +0    -1    applets/trash/package/contents/ui/main.qml
M  +0    -1    kcms/touchpad/applet/qml/contents/ui/touchpad.qml

https://commits.kde.org/plasma-desktop/eeab79954d7dc5c093d7ed248f255c7232641d15
Comment 7 Patrick Silva 2020-05-10 10:40:36 UTC
Tooltip of lock/logout widget added to plasma panel is still showing an icon
on Neon unstable.

And an app icon added to plasma panel via "Add to panel (widget)" option of context menu of kickoff also shows an icon in its tooltip. Is this intentional?
Comment 8 Nate Graham 2020-05-11 17:01:03 UTC
lock/logout still showing an icon is probably just Neon not having updated the package yet, Wait a few days.

Will fix the icon applet.
Comment 9 Nate Graham 2020-05-11 17:06:07 UTC
Git commit 65f06786f6009896ffa7d929fde114d3650a1255 by Nate Graham.
Committed on 11/05/2020 at 17:05.
Pushed by ngraham into branch 'master'.

[applets/icon] Remove icon from tooltip

Ref T12778

M  +0    -1    applets/icon/package/contents/ui/main.qml

https://commits.kde.org/plasma-workspace/65f06786f6009896ffa7d929fde114d3650a1255
Comment 10 Patrick Silva 2020-05-11 17:10:54 UTC
The issue with lock/logout widget was already fixed with today's updates. :)