Bug 420924 - After I apply "Always show all entries" setting in systray settings, the arrow to show hidden systray icons is still present until it is clicked
Summary: After I apply "Always show all entries" setting in systray settings, the arro...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray widget (show other bugs)
Version: master
Platform: Neon Linux
: NOR minor
Target Milestone: 1.0
Assignee: Konrad Materka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-02 21:13 UTC by Patrick Silva
Modified: 2020-05-07 15:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screen recording (1.69 MB, video/webm)
2020-05-02 21:13 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-05-02 21:13:31 UTC
Created attachment 128101 [details]
screen recording

STEPS TO REPRODUCE
1. open system tray settings, check "Always show all entries" and apply the change

OBSERVED RESULT
Notice that the arrow to show hidden systray icons unexpectedly is still present.
Click on it and it disappears as expected after the step above.
Watch the attached screen recording please.

EXPECTED RESULT
the arrow to show hidden systray icons should immediately disappear from
the systray after we apply "Always show all entries" setting.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-05-07 14:07:07 UTC
Will be fixed with https://phabricator.kde.org/D28180
Comment 2 Konrad Materka 2020-05-07 15:01:37 UTC
Git commit b34e88da7a5d373ba10e266e01dfefa9cef9bfb9 by Konrad Materka.
Committed on 07/05/2020 at 14:27.
Pushed by kmaterka into branch 'master'.

[applets/systemtray] Hide/show expander arrow - regression fix

Summary:
Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.

Test Plan:
* select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
* select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly

Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson

Reviewed By: #plasma_workspaces, #plasma, broulik, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28180

M  +1    -1    applets/systemtray/package/contents/ui/ExpanderArrow.qml
M  +11   -0    applets/systemtray/package/contents/ui/HiddenItemsView.qml

https://commits.kde.org/plasma-workspace/b34e88da7a5d373ba10e266e01dfefa9cef9bfb9