Bug 420799 - Konsole: input method window are not shown under cursor
Summary: Konsole: input method window are not shown under cursor
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-30 12:06 UTC by Fuminobu TAKEYAMA
Modified: 2020-06-06 10:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.08


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fuminobu TAKEYAMA 2020-04-30 12:06:17 UTC
Usually, input methods (e.g., IBus, Fcitx) shows its window under cursor. However, on Konsole, they are not shown there. This is because Konsole does not notify its cursor have moved although it answers a query for input methods to get the position.

STEPS TO REPRODUCE
1. Turn on ibus-mozc
2. enter aa

OBSERVED RESULT
1. ibus-mozc's completion window pop up at random position

EXPECTED RESULT
1. the completion window pop up under the cursor

ADDITIONAL INFORMATION
Fixed code is available at:
https://invent.kde.org/ftakeyama/konsole/-/commits/fix/im-window-position
Comment 1 Christoph Feck 2020-05-14 13:51:42 UTC
Thanks for the patch. Could you please submit a merge request with your changes?
Comment 2 Fuminobu TAKEYAMA 2020-05-14 13:54:53 UTC
(In reply to Christoph Feck from comment #1)
> Thanks for the patch. Could you please submit a merge request with your
> changes?

https://invent.kde.org/kde/konsole/-/merge_requests/86
Comment 3 Kurt Hindenburg 2020-06-06 01:59:44 UTC
Git commit d86b0547ead19ab0f0e88718bca0d32fcc2a0057 by Kurt Hindenburg, on behalf of Fuminobu TAKEYAMA.
Committed on 06/06/2020 at 01:58.
Pushed by hindenburg into branch 'master'.

Notify current cursor position might be changed to input methods

This patch fixes the issue where the input method (e.g. IBus or
Fcitx) window would not be under the cursor.

Also, Qt::ImMicroFocus is depreciated so use Qt::ImCursorRectangle.
FIXED-IN: 20.08

M  +4    -1    src/TerminalDisplay.cpp

https://invent.kde.org/utilities/konsole/commit/d86b0547ead19ab0f0e88718bca0d32fcc2a0057
Comment 4 Kurt Hindenburg 2020-06-06 10:22:27 UTC
Git commit 399a551b02d8f33ea553984ab715a3d0762fffce by Kurt Hindenburg, on behalf of Fuminobu TAKEYAMA.
Committed on 06/06/2020 at 10:18.
Pushed by hindenburg into branch 'release/20.04'.

Notify current cursor position might be changed to input methods

This patch fixes the issue where the input method (e.g. IBus or
Fcitx) window would not be under the cursor.

Also, Qt::ImMicroFocus is depreciated so use Qt::ImCursorRectangle.
FIXED-IN: 20.08
(cherry picked from commit d86b0547ead19ab0f0e88718bca0d32fcc2a0057)

M  +4    -1    src/TerminalDisplay.cpp

https://invent.kde.org/utilities/konsole/commit/399a551b02d8f33ea553984ab715a3d0762fffce