SUMMARY STEPS TO REPRODUCE 1. crop an image with Gwenview (a bar appears on top) 2. click on "Save as" button of such bar 3. double click on any image except the one you cropped OBSERVED RESULT Gwenview overwrites the double clicked image without asking for confirmation EXPECTED RESULT Gwenview should ask for confirmation before overwriting a file SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.18.4 KDE Frameworks Version: 5.69.0 Qt Version: 5.14.2
Interesting. In save mode, the file dialog should have taken care of asking.
It's caused by using KFileCustomDialog, which lacks the code to handle the safety net.
Sorry, I was wrong. Gwenview just misses the "setConfirmOverwrite(true);" line. https://cgit.kde.org/gwenview.git/tree/app/gvcore.cpp#n107
Can confirm I just noticed this, too. My process wasn't by means of clicking any files, just selecting a different image format, which kept the file name and changed the extension. If another file with this name and the "new" extension already existed, it was overwritten without question.
(In reply to Christoph Feck from comment #3) > Sorry, I was wrong. > > Gwenview just misses the "setConfirmOverwrite(true);" line. > > https://cgit.kde.org/gwenview.git/tree/app/gvcore.cpp#n107 Is this fixed? If not, I'd like to volunteer
Sure, get involved :) https://community.kde.org/Get_Involved Please assign the bug to yourself so that others can see you are preparing a patch by clicking (take) and setting the status to ASSIGNED.
Git commit b41631b229b6513137535a71436750d42c674bc5 by Nate Graham, on behalf of Marijan Smetko. Committed on 26/05/2020 at 17:18. Pushed by ngraham into branch 'master'. Add file overwrite prompt when saving a file FIXED-IN: 20.08.0 M +1 -0 app/gvcore.cpp https://invent.kde.org/graphics/gwenview/commit/b41631b229b6513137535a71436750d42c674bc5
*** Bug 423869 has been marked as a duplicate of this bug. ***
*** Bug 425546 has been marked as a duplicate of this bug. ***