Bug 420501 - branchme/tarme does not work for calligra
Summary: branchme/tarme does not work for calligra
Status: RESOLVED FIXED
Alias: None
Product: releaseme
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-24 08:58 UTC by Dag Andersen
Modified: 2020-04-27 11:48 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dag Andersen 2020-04-24 08:58:40 UTC
SUMMARY
I run e.g:
tarme.rb --version 3.2.0 --origin trunk calligra/calligra
works fine, but notice the calligra/calligra.
If I only use calligra I get all projects under calligra, I think (calligra, kexi, calligraplan)

My release_data:
calligra;master;7e9fdd313f8efd6a10c8bec9ced6412cefad144c;calligra-3.2.0.tar.xz;7e556228665d79e67c062fd1173d6676f0b0d7ceefdd6e1b0bcf9a781ea70951

Also kexi and calligraplan works fine by just specifing project name, eg:
tarme.rb --version 3.2.0 --origin trunk calligraplan


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Harald Sitter 2020-04-24 09:30:20 UTC
In the repo-metadata calligra is ambiguous. It can mean 'calligra' the module or 'calligra/calligra' the repo within that module. The fact that it tars all calligra/* when you just calligra is by design to allow easier releasing of entire modules. For example when one wants to release 'plasma' one could just run tarme on the module rather than individually for each repo within that module.

Of course since the invention of that feature it turned out that modules do not actually scale at all and may as well be done away with. Perhaps the best course of action is to drop the module release feature. I am not sure anyone is actually using it anyway.
Comment 2 Dag Andersen 2020-04-24 09:40:11 UTC
Well, calligra does not (and afaics,  will not) use the modele feature, as the reason for splitting in the first place is to allow for separate releases.
Comment 3 Harald Sitter 2020-04-24 09:43:38 UTC
You'll likely just to talk to sysadmins about moving the calligra repos to the relevant modules then (extragear/playground/apps/whatever). I don't think there is much or any benefit from sitting in a module that means nothing ^^
Comment 4 Dag Andersen 2020-04-24 09:49:08 UTC
Yes, it's probably just history...

Q: As a workaound, would it be possible to just change the project name in release_data file manually to calligra/calligra?
Or would something else break?
Comment 5 Harald Sitter 2020-04-24 10:11:27 UTC
Shouldn't break anything.
Comment 6 Harald Sitter 2020-04-27 11:48:57 UTC
Git commit 29fae7cfdb3a97add6f576cc87e0ee4639c69c7f by Harald Sitter.
Committed on 27/04/2020 at 11:31.
Pushed by sitter into branch 'master'.

throw away nesting support

this was originally intended to allow batch releasing of modules but
that turned out to be useless since projects can move between modules
with legacy releases being in one module and preview releases being
in another rendering this a useless feature

nobody seems to rely on it from a quick thread on the release team list

from_xpath is now deprecated in favor of from_find. passing by absolute
path is no longer supported and as a side effect all projects are now
presumed implicitly unique. should there be projects for which that is not
the case we'll raise in from_find now

M  +1    -1    branchme.rb
M  +11   -9    lib/releaseme/project_api_overlay.rb
M  +1    -1    logme.rb
M  +1    -1    tagme.rb
M  +1    -1    tarme.rb
M  +10   -49   test/project_test.rb

https://commits.kde.org/releaseme/29fae7cfdb3a97add6f576cc87e0ee4639c69c7f