Bug 420457 - Encrypt file icon is dark in breeze dark icon theme.
Summary: Encrypt file icon is dark in breeze dark icon theme.
Status: RESOLVED FIXED
Alias: None
Product: kgpg
Classification: Applications
Component: general (show other bugs)
Version: git
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Rolf Eike Beer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-23 12:38 UTC by Atif
Modified: 2020-04-24 18:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.08.0


Attachments
Encrypt file icon is dark in breeze dark icon theme. (52.38 KB, image/png)
2020-04-23 12:38 UTC, Atif
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Atif 2020-04-23 12:38:08 UTC
Created attachment 127793 [details]
Encrypt file icon is dark in breeze dark icon theme.

SUMMARY


STEPS TO REPRODUCE
1. Right click on any file
2. Look at encrypt file icon.
3. the end

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2020-04-23 14:41:03 UTC
I think this menu item comes from a 3rd-party Dolphin service. Can you find which one it is?
Comment 2 Atif 2020-04-24 08:55:29 UTC
It might be related to this.

Name            : plasma-vault
Version         : 5.18.4.1-1
Description     : Plasma applet and services for creating encrypted vaults
Architecture    : x86_64
URL             : https://www.kde.org/
Licenses        : LGPL
Groups          : plasma
Provides        : None
Depends On      : plasma-workspace  networkmanager-qt
Optional Deps   : encfs: to use encFS for encryption
                  cryfs: to use cryFS for encryption
Conflicts With  : None
Replaces        : None
Download Size   : 319.18 KiB
Installed Size  : 1309.36 KiB
Packager        : Antonio Rojas <arojas@archlinux.org>
Build Date      : Tue 31 Mar 2020 10:56:13 PM +06
Validated By    : MD5 Sum  SHA-256 Sum  Signature
Comment 3 Nate Graham 2020-04-24 18:32:36 UTC
No, Plasma Vault doesn't have a Dolphin plugin that would add this menu item.

I found the problem though. This menu item comes from kgpg, which tells Dolphin to use the `kgpg` icon. That icon is an app icon that does not automatically change its colors. It also looks broken-ish at small sizes.

We need to do one of two options:
1. Use a more semantically appropriate icon for the menu item (e.g. `document-encrypt`
2. Make kgpg's own icon look more like an app icon, rather than a monochrome action icon (see https://hig.kde.org/style/icons/colorful/application.html)

Both should probably be done, but #1 is more important for fixing this bug. Moving to `kgpg`
Comment 4 Nate Graham 2020-04-24 18:40:38 UTC
Git commit b331032ecfb56ebb652ceb552d40b62ca942d9f5 by Nate Graham.
Committed on 24/04/2020 at 18:39.
Pushed by ngraham into branch 'master'.

Use semantically correct icon for Dolphin addon menu items

Using `kgpg` as the icons is not semantically correct and results in the
icons being illegible whith dark color schemes because `kgpg` is an app
icon and app icons don't change their colors, but it has the appearance
of a monochrome color-changing icon.
FIXED-IN: 20.08.0

M  +1    -1    encryptfile.desktop
M  +1    -1    viewdecrypted.desktop

https://commits.kde.org/kgpg/b331032ecfb56ebb652ceb552d40b62ca942d9f5