Bug 420406 - Images in a Kirigami.Card clip outside of bounds
Summary: Images in a Kirigami.Card clip outside of bounds
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Arjen Hiemstra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-22 01:44 UTC by Janet Blackquill
Modified: 2020-04-23 09:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janet Blackquill 2020-04-22 01:44:47 UTC
Before (no clipping due to square edges): 
https://images2.imgbox.com/f0/da/3LRH9lLJ_o.png
After (images ignore rounded bounds):
https://images2.imgbox.com/fc/e0/eoIIBRYH_o.png

Introduced with https://commits.kde.org/kirigami/e770b0ddd2af7fc861be45044476b4fa062ccc1d
Comment 1 Arjen Hiemstra 2020-04-22 12:43:39 UTC
Fixed with https://phabricator.kde.org/D29092
Comment 2 Arjen Hiemstra 2020-04-23 09:01:10 UTC
Git commit 5dfa3e9e983bdd29cbb9f34d31b7bab50089430b by Arjen Hiemstra.
Committed on 23/04/2020 at 09:01.
Pushed by ahiemstra into branch 'master'.

Various fixes to new Cards

Summary:
This contains various small fixes to the new Cards.

- Still show the border of AbstractCard on Cards with images.
- Round bottom corners of the banner when the card doesn't have any other contents.
- Don't use fwidth for smoothing, instead just use a fixed value, this increases the accuracy of lines rendered by cards.
- Fix batching test for ShadowedTexture, prevents cards being rendered with the wrong texture.

Test Plan: The new Kirigami Gallery displays more correct now, though there are some layout issues that are not regressions.

Reviewers: #kirigami, ndavis, mart

Reviewed By: #kirigami, ndavis, mart

Subscribers: ndavis, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D29092

M  +12   -7    src/controls/Card.qml
M  +2    -0    src/controls/private/BannerImage.qml
M  +4    -38   src/scenegraph/shaders/sdf.glsl
M  +6    -3    src/scenegraph/shadowedbordertexturematerial.cpp
M  +6    -3    src/scenegraph/shadowedtexturematerial.cpp

https://commits.kde.org/kirigami/5dfa3e9e983bdd29cbb9f34d31b7bab50089430b