Bug 420400 - Emptying Trash does not provide any feedback that it is active/running
Summary: Emptying Trash does not provide any feedback that it is active/running
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Trash (show other bugs)
Version: 7.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-21 21:06 UTC by madal254
Modified: 2020-04-24 19:44 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 7.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description madal254 2020-04-21 21:06:43 UTC
SUMMARY

With a few thousand 130Mb files in the digiKam trash folder, I selected Delete => All Items Permanently, and hit "yes" to start the process. Nothing seemed to happen as there was no feedback (that I could see) of any kind.

At this point I assumed that it had not initiated the delete and tried again, with no result. 

About a minute later the original "empty trash operation" finished, but during that time I had no idea if the delete was active, or if something had gone wrong.

I am not sure quite why deleting around 2000 files from a local SSD drive should have taken so long, but ultimately thats not the primary issue here, although it is obviously related.

The real issue was that there was no feedback to indicate that the "empty trash" operation was in progress. Shouldn't there be some kind of feedback when an operation is active? 

STEPS TO REPRODUCE
1. Delete a large number of large files
2. Got to digiKam Trash
3. Selected Delete => All Items Permanently => yes

OBSERVED RESULT

No indication that a delete was in progress

EXPECTED RESULT

An indication that a delete was in progress

SOFTWARE/OS VERSIONS
Windows:         Windows 10
digiKam Version: 7.0.0-beta2

ADDITIONAL INFORMATION

I don't believe that there were any other active digiKam processes active when I ran into this issue.
Comment 1 Maik Qualmann 2020-04-24 19:44:43 UTC
Git commit 2c19b6daffbeaa7dc35eaa989d50410474b3b60e by Maik Qualmann.
Committed on 24/04/2020 at 19:42.
Pushed by mqualmann into branch 'master'.

show progressbar in the status bar for empty trash
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +9    -4    core/app/views/stack/trashview.cpp
M  +18   -2    core/libs/database/utils/ifaces/dio.cpp
M  +4    -0    core/libs/database/utils/ifaces/dio.h
M  +11   -4    core/libs/iojobs/iojob.cpp
M  +3    -4    core/libs/iojobs/iojob.h
M  +32   -11   core/libs/iojobs/iojobdata.cpp
M  +23   -16   core/libs/iojobs/iojobdata.h
M  +4    -14   core/libs/iojobs/iojobsmanager.cpp
M  +0    -7    core/libs/iojobs/iojobsmanager.h
M  +4    -4    core/libs/iojobs/iojobsthread.cpp
M  +2    -2    core/libs/iojobs/iojobsthread.h

https://invent.kde.org/kde/digikam/commit/2c19b6daffbeaa7dc35eaa989d50410474b3b60e