When Fill tool's Fast Mode is enabled, the checkboxes of "Fill Entire Selection", "Limit to current layer" and "Use Pattern" are locked. But they all work as intended regardless of Fast mode's state. We should allow the user to toggle them all the time. I think we should group Fast mode and the stuff it really affect, and keep others separated: Fast mode: [X] Threshold: [----------X----------] Grow selection: [----------X----------] Feathering radious: [----------X----------] -------------------------------------------------- Fill entire selection: [X] Limit to current layer: [X] Fill Pattern instead: [X]
Note: - fill entire selection is *not* locked when the fast mode is used (which is correct) - limit to current layer is locked, but - for the fast mode is doesn't matter, since it is always limited to current layer (so it's correct here - although, note, it can be considered a bug/potential wish that it only uses the current layer) (side note: now instead of the checkbox there is Sample combobox option with another combobox to choose (a) color label(s)) - fill pattern instead is locked, while the fast mode uses it. So here there is a bug. There are new options in the Fill Tool that could be grouped nicely, since it's even more of a mess now. 1) Sample options: there are three, and one of them enabled another combobox, "color label used" 2) "use selection as boundaries" checkbox 3) pattern options: rotation and scale
I want to fix the pattern issue. The thing is: when the fast mode is selected, should be allowed filling with pattern? I think that the fact that it is disabled in the ui reflects that someone thought it shouldn't. Looking at the code, if the "use pattern" option is selected then the fast mode is only used to avoid the "grow/shrink" and "feather", so the effect is the same as using the "non-fast mode" without using those. The fact is that filling with a pattern is slower, so I don't know if that should be allowed in fast mode. Before there was a reason, and that was having hard edges, only possible in the "fast mode", but now that is possible in the normal mode setting "opacity spread" to 100%.
Another issue is that when "fast mode" is selected, all the region is filled regardless of the current selection, but if "use pattern" is also selected, then the selection is applied (which is also slower). As I said earlier: if the "use pattern" option is selected then the fast mode is only used to avoid the "grow/shrink" and "feather", so it is the same in any other regard to the "non-fast mode". It has to use additional compositing.
I think I should leave the judgement to you. I might have reported this issue when I was translating the documentation, and found its behavior confusing. But it has been 2 years since the bug was initially reported, and I have no idea what I was talking about anymore. I don't recall using this function at all in my own work, and I don't think I want to figure this out again, sorry.
After the fill tool revamp, the "fast mode" is enabled automatically when applicable, so it is not exposed to the user anymore. https://invent.kde.org/graphics/krita/-/merge_requests/1360
Thanks!