Bug 420240 - Search results: don't show parent categories when none of their children appear
Summary: Search results: don't show parent categories when none of their children appear
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.19.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-04-18 11:11 UTC by Bernie Innocenti
Modified: 2022-09-08 04:52 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernie Innocenti 2020-04-18 11:11:03 UTC
SUMMARY

This is an odd bug: "Account Details" works just fine if you click on it, but you can't click on it in the search results.

Same behavior in Icon View and Sidebar View.


STEPS TO REPRODUCE
1. Start typing "account" in the search bar

OBSERVED RESULT
"Account Details" is grayed, while "Online Accounts" is selectable.


EXPECTED RESULT
Both should be selectable.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-04-20 19:21:10 UTC
How bizarre. Can reproduce.
Comment 2 Bernie Innocenti 2020-06-13 17:15:45 UTC
Still present in 5.19.0
Comment 3 alpemwarrior 2020-06-29 07:12:43 UTC
Because it contains multiple items, opening it crashes as reported in bug #423638. It should be grayed out as are all items with multiple items inside.
Comment 4 Bernie Innocenti 2020-06-29 18:52:35 UTC
(In reply to alpemwarrior from comment #3)
> Because it contains multiple items, opening it crashes as reported in bug
> #423638. It should be grayed out as are all items with multiple items inside.

If it's not a bug, it's a quite confusing UX. Why wouldn't the search results let you click on items that are normally clickable in the list? Either:

1. hide grayed out entries with no children
2. show grayed entries along with all children (even when they don't match)
3. allow selecting these entries (my preferred behavior)
Comment 5 Srevin Saju 2020-06-29 19:29:37 UTC
Also happens for "Settings" (Network sub heading).
* Attempt to click on "Settings" (works)
* Search for Settings, the "Settings" in the pane is greyed / disabled.

PS: Also happens for "Regional Settings"
Comment 6 Nate Graham 2020-06-29 20:06:43 UTC
That's the parent category appearing in the search. I guess the bug is that we shouldn't show any parent categories that have no children in the search results.
Comment 7 Nate Graham 2022-09-08 04:52:04 UTC
Seems to be fixed now.