Bug 420231 - The UI glitches while using Outline Selection Tool and holding Cmd
Summary: The UI glitches while using Outline Selection Tool and holding Cmd
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-18 06:36 UTC by Yu-Hsuan Lai
Modified: 2020-04-29 05:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
the glitch (33.36 KB, image/png)
2020-04-18 06:36 UTC, Yu-Hsuan Lai
Details
the video showing the buggy operation (159.74 KB, video/mp4)
2020-04-22 04:55 UTC, Yu-Hsuan Lai
Details
system log 1 (4.9.2) (5.60 KB, text/plain)
2020-04-26 12:18 UTC, Yu-Hsuan Lai
Details
system log 2 (nightly build) (2.50 KB, text/plain)
2020-04-26 12:18 UTC, Yu-Hsuan Lai
Details
the selection is inverted (240.99 KB, video/mp4)
2020-04-28 04:20 UTC, Yu-Hsuan Lai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yu-Hsuan Lai 2020-04-18 06:36:56 UTC
Created attachment 127630 [details]
the glitch

SUMMARY
Holding Cmd seems to allow Outline Selection Tool to draw straight lines, similar to Polygon Selection Tool. But instead it causes UI glitches.

STEPS TO REPRODUCE
1. Switch to Outline Selection Tool.
2. Draw a curve, but don't close the outline
3. Holding Cmd.
4. Click on canvas.

OBSERVED RESULT
It does nothing but glitches the UI. See attachment.

EXPECTED RESULT
A straight segment should be added to the current unfinished selection outline.

SOFTWARE/OS VERSIONS
macOS: 10.14.6
Krita: Nightly build (44e3f62)

ADDITIONAL INFORMATION
Same with 4.2.9.
Comment 1 vanyossi 2020-04-22 04:10:16 UTC
Im sorry but I couldn't reproduce the issue with the instructions given. If I make a curve and lift the pen the selection is created. Then pressing and Hold Cmd and click on canvas creates a new selection.

Could you explain some more or post a video that shows the issue?

Tested on macos 10.14.6 krita (94a83a7)
Comment 2 Yu-Hsuan Lai 2020-04-22 04:55:50 UTC
Created attachment 127769 [details]
the video showing the buggy operation
Comment 3 Yu-Hsuan Lai 2020-04-22 04:56:40 UTC
(In reply to vanyossi from comment #1)
> Im sorry but I couldn't reproduce the issue with the instructions given. If
> I make a curve and lift the pen the selection is created. Then pressing and
> Hold Cmd and click on canvas creates a new selection.
> 
> Could you explain some more or post a video that shows the issue?
> 
> Tested on macos 10.14.6 krita (94a83a7)

Sure. I attached a video. Hope it makes things clearer!
Comment 4 Bug Janitor Service 2020-04-23 04:33:12 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 wolthera 2020-04-24 11:42:43 UTC
This is a problem caused by the fact that the canvas isn't using graphics acceleration. We implemented graphics acceleration via opengl to resolve issues like these, though it can be turned off when your device's opengl support is terrible. I recommend turning on graphics acceleration in the preferences, or just living with the glitch.
Comment 6 Yu-Hsuan Lai 2020-04-24 11:52:14 UTC
(In reply to wolthera from comment #5)
> This is a problem caused by the fact that the canvas isn't using graphics
> acceleration. We implemented graphics acceleration via opengl to resolve
> issues like these, though it can be turned off when your device's opengl
> support is terrible. I recommend turning on graphics acceleration in the
> preferences, or just living with the glitch.

Well canvas acceleration is practically unusable on som3 Mac (see Bug 419783). And it's not a visual glitch only, but functionality issue too. So I think at least one of these two should be considered a confirmed bug.
Comment 7 Yu-Hsuan Lai 2020-04-24 11:53:54 UTC
Uh, actually this issue still happens to me with canvas acceleration on.
Comment 8 vanyossi 2020-04-26 05:52:21 UTC
Does this happen with canvas acceleration turned on using 4.2.9 or only in master?

I cannot get it to happen with opencGL turned on in any mode. High quality, triliniear, nearest Neighbour, in any version.

Also please attach the information in from menu: Help -> Show system information for bug reports.
Comment 9 Yu-Hsuan Lai 2020-04-26 12:18:00 UTC
Created attachment 127890 [details]
system log 1 (4.9.2)
Comment 10 Yu-Hsuan Lai 2020-04-26 12:18:36 UTC
Created attachment 127891 [details]
system log 2 (nightly build)
Comment 11 Yu-Hsuan Lai 2020-04-26 12:19:48 UTC
It happens to me with any combination of (4.9.2, nightly) and (canvas acceleration on, canvas acceleration off).

No discernible difference.
Comment 12 Bug Janitor Service 2020-04-27 04:33:13 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 13 Yu-Hsuan Lai 2020-04-28 04:20:01 UTC
Created attachment 127936 [details]
the selection is inverted
Comment 14 Yu-Hsuan Lai 2020-04-28 04:21:10 UTC
In 4.3.0 (git 2bae978), the UI glitch doesn't happen. However it selects the "outside" of my intended region. Is this normal? (See the latest attachment)
Comment 15 vanyossi 2020-04-28 21:15:40 UTC
Its normal if you press "alt" while releasing the selection action. Notice how in the video you can see selection change to substract mode (the minus sign). so instead of replacing the selection it substracts from your current selection.

Im closing this bug as you no longer can reproduce the behaviour in 4.3

If you have other problems with selection open a different bug to give every issue a better follow up.
Comment 16 Yu-Hsuan Lai 2020-04-29 05:25:47 UTC
(In reply to vanyossi from comment #15)
> Its normal if you press "alt" while releasing the selection action. Notice
> how in the video you can see selection change to substract mode (the minus
> sign). so instead of replacing the selection it substracts from your current
> selection.
> 
> Im closing this bug as you no longer can reproduce the behaviour in 4.3
> 
> If you have other problems with selection open a different bug to give every
> issue a better follow up.

Yeah but I were 100% not press "alt"...

Anyway I'll submit another bug report for that.
Comment 17 Yu-Hsuan Lai 2020-04-29 05:47:18 UTC
Ok, please follow up at Bug 420737